chore: windows tests should preserve yarn.lock #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #295 +/- ##
=======================================
Coverage 80.33% 80.33%
=======================================
Files 13 13
Lines 1490 1490
Branches 556 556
=======================================
Hits 1197 1197
Misses 122 122
Partials 171 171 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
styfle
changed the title
ijjk
approved these changes
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows tests should preserve yarn.lock
In the future we might want to use
--frozen-lockfilebut for now this will prevent windows tests from inadvertently upgrading dependencies.