Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output warnings and errors from webpack individually #5442

Merged
merged 1 commit into from
Oct 20, 2018

Conversation

timmywil
Copy link
Contributor

- Shows warnings even when resolving, to facilitate hints set to 'warning'
- Fixes vercel#876 : Set performance.hints to 'warning' or 'error' in next.config.js
@timneutkens
Copy link
Member

Do you have a screenshot for this? Curious how it looks.

@timmywil
Copy link
Contributor Author

timmywil commented Oct 12, 2018

Sure.

Warning mode:
screenshot 2018-10-12 11 07 40

Error mode:
screenshot 2018-10-12 11 08 17

There's no colors, but this just allows next users to take advantage of existing functionality in webpack. It's the missing piece to hook up readable size budgets in PRs and/or integration branches. PR builds would properly fail in CI by setting hints to 'error', and warnings can be just that: warnings that don't cause a failure in CI.

@timneutkens timneutkens merged commit 1b8f565 into vercel:canary Oct 20, 2018
@timmywil timmywil deleted the stats-output branch November 12, 2018 20:08
@lock lock bot locked as resolved and limited conversation to collaborators Nov 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display bundle sizes after build
2 participants