Initial dev server #5317
Merged
Initial dev server #5317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HaNdTriX
approved these changes
Sep 28, 2018
giuseppeg
approved these changes
Sep 28, 2018
server/index.js
Outdated
| @@ -23,7 +23,6 @@ import pkg from '../../package' | |||
| export default class Server { | |||
| constructor ({ dir = '.', dev = false, staticMarkup = false, quiet = false, conf = null } = {}) { | |||
| this.dir = resolve(dir) | |||
| this.dev = dev | |||
| this.quiet = quiet | |||
| this.router = new Router() | |||
| const phase = dev ? PHASE_DEVELOPMENT_SERVER : PHASE_PRODUCTION_SERVER | |||
There was a problem hiding this comment.
you could probably get rid of dev if you use the constructor only to define instance configuration and then add a init method to the class which you'd call explicitly. This way the dev server could do the extra work inside its constructor
There was a problem hiding this comment.
Yeah, this is just the first wave of changes, I'm going to progressively move more code to the dev server 👍
HaNdTriX
reviewed
Sep 28, 2018
| async prepare () { | ||
| await super.prepare() | ||
| if (this.hotReloader) { | ||
| await this.hotReloader.start() |
There was a problem hiding this comment.
We can now omit these checks.
if (this.hotReloader) ...
timneutkens
added a commit
that referenced
this pull request
Sep 28, 2018
Remove `if(this.hotReloader)` as it's always guaranteed to be there. #5317 (comment)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move all parts that rely on
this.devinto it's own server that is built on top of the default server.