Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Middleware documentation #37992

Closed
wants to merge 48 commits into from
Closed

Update Middleware documentation #37992

wants to merge 48 commits into from

Conversation

ismaelrumzan
Copy link
Contributor

This PR is a follow-up from #37514 to implement additional feedback.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

molebox and others added 23 commits June 7, 2022 16:19
@molebox
Initial outline added for middleware docs
f903c34
@molebox
Feedback changes - not included new user agent yet
08c812e
@molebox
Merge branch 'canary' into middleware-docs
8f10228
@molebox
edge api routes docs
9476a0b
@molebox
middleware page some cleanup
879d58c
@molebox
Merge branch 'canary' into middleware-docs
273dec4
@molebox
moved api stuff to next server, added useragent
861b526
@molebox
waitUntil example added
bf087f4
@molebox
Updated env vars section
47e37b5
@molebox
Merge branch 'canary' into middleware-docs
cae2e64
@molebox
Added cookies on the request object example
4e9c1bf
@molebox
Merge branch 'canary' into middleware-docs
3176b4e
@molebox
fixed naming
7291023
@molebox
fixed import typo
82b18b8
@molebox
Merge branch 'canary' into middleware-docs
b5d0d41
@molebox
Amy feedback
45e528f
@molebox @timeyoutakeit
Update docs/advanced-features/middleware.md
1e97c04 
Co-authored-by: Amy Burns <amy.burns@vercel.com>
@ismaelrumzan
first commit
d97c754
@ismaelrumzan
more fixes
a5f5a8e
@ismaelrumzan
re-structuring based on feedback
b172775
@ismaelrumzan
changes to middleware.md
098db80
@ismaelrumzan
updates to edge-api-routes
175a14f
@ismaelrumzan
code typo
b91774b
Nutlope
Nutlope reviewed Jun 27, 2022
View reviewed changes
docs/api-routes/edge-api-routes.md Outdated Show resolved Hide resolved
docs/api-routes/edge-api-routes.md Outdated Show resolved Hide resolved
docs/advanced-features/middleware.md Outdated Show resolved Hide resolved
docs/advanced-features/middleware.md Show resolved Hide resolved
jescalan
jescalan previously approved these changes Jun 27, 2022
View reviewed changes
docs/advanced-features/middleware.md Outdated Show resolved Hide resolved
docs/advanced-features/middleware.md Show resolved Hide resolved
docs/advanced-features/middleware.md Outdated Show resolved Hide resolved
docs/advanced-features/middleware.md Outdated Show resolved Hide resolved
docs/advanced-features/middleware.md Outdated Show resolved Hide resolved
docs/advanced-features/middleware.md Show resolved Hide resolved
docs/api-routes/edge-api-routes.md Outdated Show resolved Hide resolved
leerob and others added 3 commits June 27, 2022 15:15
jescalan
jescalan suggested changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@jescalan jescalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjustments to security claims around edge runtime

docs/advanced-features/react-18/switchable-runtime.md Outdated Show resolved Hide resolved
docs/api-routes/edge-api-routes.md Outdated Show resolved Hide resolved
ismaelrumzan and others added 2 commits June 28, 2022 08:49
@ismaelrumzan @jescalan
Update docs/advanced-features/react-18/switchable-runtime.md
bb2a562 
Co-authored-by: Jeff Escalante <jescalan@users.noreply.github.com>
@ismaelrumzan @jescalan
Update docs/api-routes/edge-api-routes.md
efe31e6 
Co-authored-by: Jeff Escalante <jescalan@users.noreply.github.com>
jescalan
jescalan previously approved these changes Jun 28, 2022
View reviewed changes
@leerob
Copy link
Member

leerob commented Jun 28, 2022

One small lint error then let's roll!

@leerob @javivelasco
Update docs/advanced-features/react-18/switchable-runtime.md
877cd0c 
Co-authored-by: Javi Velasco <javier.velasco86@gmail.com>
@ijjk ijjk mentioned this pull request Jun 28, 2022
Merged
2 tasks
@ijjk
Copy link
Member

ijjk commented Jun 28, 2022

Continued in #38111

@ijjk ijjk closed this Jun 28, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@javivelasco javivelasco javivelasco left review comments

@timeyoutakeit timeyoutakeit timeyoutakeit left review comments

@leerob leerob leerob left review comments

@balazsorban44 balazsorban44 balazsorban44 left review comments

@ijjk ijjk ijjk left review comments

@Nutlope Nutlope Nutlope left review comments

@jescalan jescalan jescalan approved these changes

@cramforce cramforce cramforce left review comments

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@styfle styfle Awaiting requested review from styfle

@huozhi huozhi Awaiting requested review from huozhi

@padmaia padmaia Awaiting requested review from padmaia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@ismaelrumzan @balazsorban44 @leerob @ijjk @cramforce @jescalan @javivelasco @timeyoutakeit @Nutlope @molebox