Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Middleware error guide from .js to .ts. #37858

Merged
merged 1 commit into from
Jun 20, 2022
Merged

Change Middleware error guide from .js to .ts. #37858

merged 1 commit into from
Jun 20, 2022

Conversation

leerob
Copy link
Member

@leerob leerob commented Jun 20, 2022

Feedback:

Hello :D may it be that the types should be imported in a TS file, so I think the extension of the file should be updated here :) /middleware.js -> /middleware.ts (or no types)

@kodiakhq kodiakhq bot merged commit f3c1bcf into canary Jun 20, 2022
@kodiakhq kodiakhq bot deleted the leerob-patch-1 branch June 20, 2022 21:56
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@huozhi huozhi Awaiting requested review from huozhi

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leerob @ijjk