Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(examples): fix active-class-name example #37828

Merged
merged 5 commits into from
Jun 21, 2022
Merged

chore(examples): fix active-class-name example #37828

merged 5 commits into from
Jun 21, 2022

Conversation

balazsorban44
Copy link
Member

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

@ijjk ijjk added the examples Issue/PR related to examples label Jun 19, 2022
@balazsorban44 balazsorban44 marked this pull request as ready for review June 19, 2022 21:59
@balazsorban44 balazsorban44 requested a review from ijjk June 21, 2022 10:20
@kodiakhq kodiakhq bot merged commit c04a6b0 into canary Jun 21, 2022
@kodiakhq kodiakhq bot deleted the docs/link-to-referenced-example branch June 21, 2022 15:44
@ijjk ijjk mentioned this pull request Jun 22, 2022
Merged
3 tasks
kodiakhq bot pushed a commit that referenced this pull request Jun 22, 2022
@ijjk
Fix styled-jsx types when package is not hoisted (#37902)
c4dc081 
This ensures we expose the `styled-jsx` types correctly even when the package is not hoisted from next's `node_modules` e.g. when using `pnpm`. We had an existing test that covered this although it installed `styled-jsx` at the top-level as a workaround so the test has been updated to remove this workaround. 

## Bug

- [x] Related issues linked using `fixes #number`
- [x] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

Fixes: #37828 (comment)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@leerob leerob Awaiting requested review from leerob

@steven-tey steven-tey Awaiting requested review from steven-tey

@styfle styfle Awaiting requested review from styfle

@huozhi huozhi Awaiting requested review from huozhi

@padmaia padmaia Awaiting requested review from padmaia

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@balazsorban44 @ijjk