Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update usage of example.com -> example.vercel.sh #37630

Merged
merged 3 commits into from
Jun 10, 2022
Merged

Update usage of example.com -> example.vercel.sh #37630

merged 3 commits into from
Jun 10, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Jun 10, 2022

Seems we still have some usage of example.com in our tests which is very flakey so this updates to use example.vercel.sh instead.

x-ref: https://github.com/vercel/next.js/runs/6838713646?check_suite_focus=true#step:8:240

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team. label Jun 10, 2022
styfle
styfle previously approved these changes Jun 10, 2022
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a lint rule 😜

@ijjk ijjk merged commit 934e5a4 into vercel:canary Jun 10, 2022
@ijjk ijjk deleted the update/test-domain branch June 10, 2022 23:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@styfle styfle styfle approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@huozhi huozhi Awaiting requested review from huozhi

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ijjk @styfle