Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update with-mux-video to use latest upchunk and replace video player with mux-player-react #37621

Merged
merged 12 commits into from
Jun 13, 2022
Merged

Update with-mux-video to use latest upchunk and replace video player with mux-player-react #37621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
2f44582
Update upchunk to latest (2.3.1).
clearlyTHUYDOAN Jun 7, 2022
2c45342
Add mux-player package to package.json
clearlyTHUYDOAN Jun 7, 2022
ea49877
WIP: Make VideoPlayer return mux-player
clearlyTHUYDOAN Jun 7, 2022
5f51509
Remove unused code from prev video player
clearlyTHUYDOAN Jun 7, 2022
2bf7173
Use mux-player-react directly
clearlyTHUYDOAN Jun 7, 2022
6b854a7
Fix import line for mux-player-react
clearlyTHUYDOAN Jun 7, 2022
b85b8b2
Merge remote-tracking branch 'origin' into with-mux-video/update-upch…
clearlyTHUYDOAN Jun 8, 2022
35f05db
Merge remote-tracking branch 'origin' into with-mux-video/update-upch…
clearlyTHUYDOAN Jun 10, 2022
a5e56f9
Merge branch 'canary' into with-mux-video/update-upchunk-and-video-pl…
kodiakhq[bot] Jun 11, 2022
6857390
chore: fix lint issues
balazsorban44 Jun 13, 2022
2aa3703
Merge branch 'canary' into with-mux-video/update-upchunk-and-video-pl…
kodiakhq[bot] Jun 13, 2022
f87e4cd
Merge branch 'canary' into with-mux-video/update-upchunk-and-video-pl…
ijjk Jun 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 0 additions & 49 deletions examples/with-mux-video/components/video-player.js
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions examples/with-mux-video/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
},
"dependencies": {
"@mux/mux-node": "^2.8.0",
"@mux/upchunk": "^2.0.0",
"hls.js": "^0.13.2",
"@mux-elements/mux-player-react": "0.1.0-beta.19",
"@mux/upchunk": "^2.3.1",
"next": "latest",
"react": "^17.0.2",
"react-dom": "^17.0.2",
Expand Down
9 changes: 4 additions & 5 deletions examples/with-mux-video/pages/v/[id].js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,14 @@
import MuxPlayer from '@mux-elements/mux-player-react'
import Link from 'next/link'
import Layout from '../../components/layout'
import VideoPlayer from '../../components/video-player'
import Spinner from '../../components/spinner'
import { MUX_HOME_PAGE_URL } from '../../constants'
import { useRouter } from 'next/router'

export function getStaticProps({ params: { id: playbackId } }) {
const src = `https://stream.mux.com/${playbackId}.m3u8`
const poster = `https://image.mux.com/${playbackId}/thumbnail.png`

return { props: { playbackId, src, poster } }
return { props: { playbackId, poster } }
}

export function getStaticPaths() {
Expand All @@ -33,7 +32,7 @@ const Code = ({ children }) => (
</>
)

export default function Playback({ playbackId, src, poster }) {
export default function Playback({ playbackId, poster }) {
const router = useRouter()

if (router.isFallback) {
Expand All @@ -51,7 +50,7 @@ export default function Playback({ playbackId, src, poster }) {
loadTwitterWidget
>
<div className="flash-message">This video is ready for playback</div>
<VideoPlayer src={src} poster={poster} />
<MuxPlayer style={{ width: '100%' }} playbackId={playbackId} />
<p>
Go{' '}
<Link href="/">
Expand Down