update devdDependencies @types/react and @types/react-dom #37423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saurabhmehta1601
requested review from
timneutkens,
ijjk,
shuding,
leerob,
steven-tey and
balazsorban44
as code owners
|
You can't install React 18 defs if the project is using React 17. |
balazsorban44
requested changes
Jun 6, 2022
|
@saurabhmehta1601 please address my comment here, so we can merge this PR: #37423 (review) |
|
Thanks @balazsorban44 for the review . I am new to contributing to large codebases . Sorry if I have unknowingly caused any inconvenience in the process . |
|
No problem @saurabhmehta1601! I'm happy to help your first PR merged to the Next.js repo! What I meant is this: next.js/examples/with-redux/package.json Lines 13 to 14 in 756dc8f At the least, these should be upgraded as well so the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #37421