Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small code improvements #37227

Merged
merged 5 commits into from
May 26, 2022
Merged

Small code improvements #37227

merged 5 commits into from
May 26, 2022

Conversation

shuding
Copy link
Member

@shuding shuding commented May 26, 2022

Two small things noticed today. When calling getDependencies concurrently (which is happening right now) the cache doesn't work as it's after the await, so here we move it to cache the promise instead. Also NUM_OF_MICROSEC_IN_SEC isn't accurate and it should be NANOSEC actually.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint
  • The examples guidelines are followed from our contributing doc

@ijjk
Copy link
Member

ijjk commented May 26, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary shuding/next.js shu/f944 Change
buildDuration 20.3s 20.1s -186ms
buildDurationCached 7.7s 8.1s ⚠️ +486ms
nodeModulesSize 626 MB 626 MB ⚠️ +118 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary shuding/next.js shu/f944 Change
/ failed reqs 0 0
/ total time (seconds) 5.196 5.239 ⚠️ +0.04
/ avg req/sec 481.13 477.2 ⚠️ -3.93
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.074 2.085 ⚠️ +0.01
/error-in-render avg req/sec 1205.66 1199.15 ⚠️ -6.51
Client Bundles (main, webpack)
vercel/next.js canary shuding/next.js shu/f944 Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 29.2 kB 29.2 kB
webpack-HASH.js gzip 1.54 kB 1.54 kB
Overall change 73 kB 73 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/f944 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary shuding/next.js shu/f944 Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 308 B 308 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.71 kB 2.71 kB
head-HASH.js gzip 359 B 359 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.74 kB 5.74 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.65 kB 2.65 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 391 B 391 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16 kB 16 kB
Client Build Manifests
vercel/next.js canary shuding/next.js shu/f944 Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/f944 Change
index.html gzip 533 B 533 B
link.html gzip 546 B 546 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary shuding/next.js shu/f944 Change
buildDuration 24s 24.5s ⚠️ +470ms
buildDurationCached 8.2s 7.9s -223ms
nodeModulesSize 626 MB 626 MB ⚠️ +118 B
Page Load Tests Overall increase ✓
vercel/next.js canary shuding/next.js shu/f944 Change
/ failed reqs 0 0
/ total time (seconds) 5.477 5.471 -0.01
/ avg req/sec 456.45 456.95 +0.5
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.21 2.165 -0.04
/error-in-render avg req/sec 1131.43 1154.73 +23.3
Client Bundles (main, webpack)
vercel/next.js canary shuding/next.js shu/f944 Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.7 kB 42.7 kB
main-HASH.js gzip 29.7 kB 29.7 kB
webpack-HASH.js gzip 1.54 kB 1.54 kB
Overall change 74 kB 74 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/f944 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary shuding/next.js shu/f944 Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 311 B 311 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.9 kB 2.9 kB
head-HASH.js gzip 357 B 357 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.84 kB 5.84 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.78 kB 2.78 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.4 kB 16.4 kB
Client Build Manifests
vercel/next.js canary shuding/next.js shu/f944 Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/f944 Change
index.html gzip 533 B 533 B
link.html gzip 547 B 547 B
withRouter.html gzip 529 B 529 B
Overall change 1.61 kB 1.61 kB
Commit: 26b7934

@kodiakhq kodiakhq bot merged commit 37b859f into vercel:canary May 26, 2022
@shuding shuding deleted the shu/f944 branch May 27, 2022 00:13
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants