Refactor fetchFlight

[timneutkens]

• Remove __props__
• Remove refreshCache function

This only applies to client/app-index.tsx not client/index.tsx for backwards compat.

Bug

• Related issues linked using fixes #number
• Integration tests added
• Errors have helpful link attached, see contributing.md

Feature

• Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
• Related issues linked using fixes #number
• Integration tests added
• Documentation added
• Telemetry added. In case of a feature if it's used or not.
• Errors have helpful link attached, see contributing.md

Documentation / Examples

• Make sure the linting passes by running yarn lint
• The examples guidelines are followed from our contributing doc

[ijjk]

Stats from current PR

Default Build (Increase detected ⚠️)

General Overall decrease ✓

	vercel/next.js canary	timneutkens/next.js add/refactor-fetchflight	Change
buildDuration	15.9s	16.2s	⚠️ +366ms
buildDurationCached	6.5s	6.4s	-73ms
nodeModulesSize	494 MB	494 MB	-2.39 kB

Page Load Tests Overall increase ✓

	vercel/next.js canary	timneutkens/next.js add/refactor-fetchflight	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.974	3.933	-0.04
/ avg req/sec	629.15	635.6	+6.45
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.361	1.34	-0.02
/error-in-render avg req/sec	1836.51	1865.73	+29.22

Client Bundles (main, webpack)

	vercel/next.js canary	timneutkens/next.js add/refactor-fetchflight	Change
925.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42 kB	42 kB	✓
main-HASH.js gzip	29.2 kB	29.2 kB	✓
webpack-HASH.js gzip	1.54 kB	1.54 kB	✓
Overall change	73 kB	73 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js add/refactor-fetchflight	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js add/refactor-fetchflight	Change
_app-HASH.js gzip	1.36 kB	1.36 kB	✓
_error-HASH.js gzip	193 B	193 B	✓
amp-HASH.js gzip	308 B	308 B	✓
css-HASH.js gzip	327 B	327 B	✓
dynamic-HASH.js gzip	2.71 kB	2.71 kB	✓
head-HASH.js gzip	359 B	359 B	✓
hooks-HASH.js gzip	920 B	920 B	✓
image-HASH.js gzip	5.74 kB	5.74 kB	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	2.65 kB	2.65 kB	✓
routerDirect..HASH.js gzip	320 B	320 B	✓
script-HASH.js gzip	391 B	391 B	✓
withRouter-HASH.js gzip	318 B	318 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	16 kB	16 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js add/refactor-fetchflight	Change
_buildManifest.js gzip	459 B	459 B	✓
Overall change	459 B	459 B	✓

Rendered Page Sizes

	vercel/next.js canary	timneutkens/next.js add/refactor-fetchflight	Change
index.html gzip	533 B	533 B	✓
link.html gzip	546 B	546 B	✓
withRouter.html gzip	528 B	528 B	✓
Overall change	1.61 kB	1.61 kB	✓

---

Default Build with SWC (Increase detected ⚠️)

General Overall decrease ✓

	vercel/next.js canary	timneutkens/next.js add/refactor-fetchflight	Change
buildDuration	18.2s	18.2s	-7ms
buildDurationCached	6.5s	6.4s	-130ms
nodeModulesSize	494 MB	494 MB	-2.39 kB

Page Load Tests Overall increase ✓

	vercel/next.js canary	timneutkens/next.js add/refactor-fetchflight	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.918	3.957	⚠️ +0.04
/ avg req/sec	638.08	631.85	⚠️ -6.23
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.601	1.35	-0.25
/error-in-render avg req/sec	1561.42	1851.63	+290.21

Client Bundles (main, webpack)

	vercel/next.js canary	timneutkens/next.js add/refactor-fetchflight	Change
925.HASH.js gzip	178 B	178 B	✓
framework-HASH.js gzip	42.7 kB	42.7 kB	✓
main-HASH.js gzip	29.7 kB	29.7 kB	✓
webpack-HASH.js gzip	1.54 kB	1.54 kB	✓
Overall change	74 kB	74 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js add/refactor-fetchflight	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js add/refactor-fetchflight	Change
_app-HASH.js gzip	1.35 kB	1.35 kB	✓
_error-HASH.js gzip	179 B	179 B	✓
amp-HASH.js gzip	311 B	311 B	✓
css-HASH.js gzip	324 B	324 B	✓
dynamic-HASH.js gzip	2.89 kB	2.89 kB	✓
head-HASH.js gzip	357 B	357 B	✓
hooks-HASH.js gzip	920 B	920 B	✓
image-HASH.js gzip	5.84 kB	5.84 kB	✓
index-HASH.js gzip	261 B	261 B	✓
link-HASH.js gzip	2.78 kB	2.78 kB	✓
routerDirect..HASH.js gzip	322 B	322 B	✓
script-HASH.js gzip	392 B	392 B	✓
withRouter-HASH.js gzip	317 B	317 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	16.4 kB	16.4 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js add/refactor-fetchflight	Change
_buildManifest.js gzip	457 B	457 B	✓
Overall change	457 B	457 B	✓

Rendered Page Sizes

	vercel/next.js canary	timneutkens/next.js add/refactor-fetchflight	Change
index.html gzip	533 B	533 B	✓
link.html gzip	547 B	547 B	✓
withRouter.html gzip	529 B	529 B	✓
Overall change	1.61 kB	1.61 kB	✓

Commit: 0d0925f