-
Notifications
You must be signed in to change notification settings - Fork 26.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cms-kontent
example Next/Image
domain error
#37188
Merged
ijjk
merged 1 commit into
vercel:canary
from
kyan:fix-cms-kontent-example-image-loading-error
May 25, 2022
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
import NextImage from 'next/image' | ||
import { transformImageUrl } from '@kentico/kontent-delivery' | ||
|
||
const KONTENT_ASSET_HOSTNAME_REGEX = /.kc-usercontent.com$/ | ||
|
||
const getLoader = (src) => { | ||
return srcIsKontentAsset(src) ? kontentImageLoader : undefined | ||
} | ||
|
||
const srcIsKontentAsset = (src) => { | ||
try { | ||
const { hostname } = new URL(src) | ||
return KONTENT_ASSET_HOSTNAME_REGEX.test(hostname) | ||
} catch { | ||
return false | ||
} | ||
} | ||
|
||
const kontentImageLoader = ({ src, width, quality = 100 }) => { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. How about quality 75 as default? Usually 100 is much larger than necessary. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Updated in #37206 |
||
return new transformImageUrl(src) | ||
.withWidth(width) | ||
.withQuality(quality) | ||
.withCompression('lossless') | ||
.withAutomaticFormat() | ||
.getUrl() | ||
} | ||
|
||
export default function Image(props) { | ||
const loader = getLoader(props.src) | ||
|
||
return <NextImage {...props} loader={loader} /> | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the
.
be escaped? Perhaps you should usehostname.endsWith('.kc-usercontent.com')
instead of a regexpThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
endsWith
would be simpler, thanks 👍I'll open another PR to update this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated in #37206