Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use customized chunk loading implementation #37163

Merged
merged 4 commits into from
May 24, 2022
Merged

Conversation

shuding
Copy link
Member

@shuding shuding commented May 24, 2022

Follow-up PR for #37134, this PR adds back the hash in each chunk's filename. This chunks in the flight manifest will now be chunkId:chunkFilename with this PR, and globalThis.__next_chunk_load__ then handles the chunk registration (uses chunkId) and chunk loading (uses chunkFilename). (Q: how can we port this to React?)

We can't use [contenthash] but only [chunkhash] because at the stage of generating the flight manifest, the content isn't finalized and the hash changes after that.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels May 24, 2022
@ijjk
Copy link
Member

ijjk commented May 24, 2022

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary shuding/next.js shu/5825 Change
buildDuration 15.7s 16s ⚠️ +230ms
buildDurationCached 6.4s 6.4s ⚠️ +10ms
nodeModulesSize 494 MB 494 MB ⚠️ +1.1 kB
Page Load Tests Overall increase ✓
vercel/next.js canary shuding/next.js shu/5825 Change
/ failed reqs 0 0
/ total time (seconds) 3.841 3.84 0
/ avg req/sec 650.89 651.01 +0.12
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.227 1.227
/error-in-render avg req/sec 2037.14 2037.71 +0.57
Client Bundles (main, webpack)
vercel/next.js canary shuding/next.js shu/5825 Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 29.2 kB 29.2 kB
webpack-HASH.js gzip 1.54 kB 1.54 kB
Overall change 73 kB 73 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/5825 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary shuding/next.js shu/5825 Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 308 B 308 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.71 kB 2.71 kB
head-HASH.js gzip 359 B 359 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.74 kB 5.74 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.65 kB 2.65 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 391 B 391 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16 kB 16 kB
Client Build Manifests
vercel/next.js canary shuding/next.js shu/5825 Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/5825 Change
index.html gzip 533 B 533 B
link.html gzip 547 B 547 B
withRouter.html gzip 529 B 529 B
Overall change 1.61 kB 1.61 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary shuding/next.js shu/5825 Change
buildDuration 18.2s 18.2s -14ms
buildDurationCached 6.4s 6.3s -57ms
nodeModulesSize 494 MB 494 MB ⚠️ +1.1 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary shuding/next.js shu/5825 Change
/ failed reqs 0 0
/ total time (seconds) 3.818 3.855 ⚠️ +0.04
/ avg req/sec 654.87 648.43 ⚠️ -6.44
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.204 1.204
/error-in-render avg req/sec 2075.6 2077.07 +1.47
Client Bundles (main, webpack)
vercel/next.js canary shuding/next.js shu/5825 Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.7 kB 42.7 kB
main-HASH.js gzip 29.7 kB 29.7 kB
webpack-HASH.js gzip 1.54 kB 1.54 kB
Overall change 74 kB 74 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/5825 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary shuding/next.js shu/5825 Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 311 B 311 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.89 kB 2.89 kB
head-HASH.js gzip 357 B 357 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.84 kB 5.84 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.78 kB 2.78 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.4 kB 16.4 kB
Client Build Manifests
vercel/next.js canary shuding/next.js shu/5825 Change
_buildManifest.js gzip 457 B 457 B
Overall change 457 B 457 B
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/5825 Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: f6f8943

@shuding shuding marked this pull request as ready for review May 24, 2022 19:59
ijjk
ijjk previously approved these changes May 24, 2022
@kodiakhq kodiakhq bot merged commit cc254cc into vercel:canary May 24, 2022
@shuding shuding deleted the shu/5825 branch May 24, 2022 22:28
Schniz pushed a commit to Schniz/next.js that referenced this pull request May 25, 2022
Follow-up PR for vercel#37134, this PR adds back the hash in each chunk's filename. This `chunks` in the flight manifest will now be `chunkId:chunkFilename` with this PR, and `globalThis.__next_chunk_load__` then handles the chunk registration (uses chunkId) and chunk loading (uses chunkFilename). (Q: how can we port this to React?)

We can't use `[contenthash]` but only `[chunkhash]` because at the stage of generating the flight manifest, the content isn't finalized and the hash changes after that.

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `yarn lint`
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants