Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: missing parenthesis on example #37156

Merged
merged 5 commits into from
May 24, 2022
Merged

Docs: missing parenthesis on example #37156

merged 5 commits into from
May 24, 2022

Conversation

alexandrutasica
Copy link
Contributor

@alexandrutasica alexandrutasica commented May 24, 2022 •
edited
Loading

Missing close parenthesis on docs example from page custom-document-image-import.md

Bug

  • Related issues linked using fixes #37155
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@alexandrutasica alexandrutasica mentioned this pull request May 24, 2022
Closed
1 task
@alexandrutasica alexandrutasica changed the title fix missing parenthesis on example Docs: missing parenthesis on example May 24, 2022
styfle
styfle previously approved these changes May 24, 2022
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

ijjk
ijjk previously approved these changes May 24, 2022
View reviewed changes
@ijjk ijjk dismissed stale reviews from styfle and themself via d54b203 May 24, 2022 14:25
@kodiakhq kodiakhq bot merged commit e4bf1a5 into vercel:canary May 24, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@styfle styfle styfle left review comments

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexandrutasica @styfle @ijjk