Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove process.cwd usage from path polyfill #37130

Merged
merged 3 commits into from
May 23, 2022

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented May 23, 2022

Avoid process usage detection warning for edge runtime bundle

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels May 23, 2022
@ijjk
Copy link
Member

ijjk commented May 23, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary huozhi/next.js remove-pocess-usage-from-polyfill Change
buildDuration 21.5s 22s ⚠️ +488ms
buildDurationCached 8.2s 9s ⚠️ +871ms
nodeModulesSize 479 MB 479 MB -169 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js remove-pocess-usage-from-polyfill Change
/ failed reqs 0 0
/ total time (seconds) 5.757 5.749 -0.01
/ avg req/sec 434.28 434.83 +0.55
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.141 2.204 ⚠️ +0.06
/error-in-render avg req/sec 1167.84 1134.54 ⚠️ -33.3
Client Bundles (main, webpack)
vercel/next.js canary huozhi/next.js remove-pocess-usage-from-polyfill Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 29.2 kB 29.2 kB
webpack-HASH.js gzip 1.54 kB 1.54 kB
Overall change 73 kB 73 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js remove-pocess-usage-from-polyfill Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js remove-pocess-usage-from-polyfill Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 308 B 308 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.71 kB 2.71 kB
head-HASH.js gzip 359 B 359 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.73 kB 5.73 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.65 kB 2.65 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 391 B 391 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16 kB 16 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js remove-pocess-usage-from-polyfill Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js remove-pocess-usage-from-polyfill Change
index.html gzip 533 B 533 B
link.html gzip 547 B 547 B
withRouter.html gzip 529 B 529 B
Overall change 1.61 kB 1.61 kB

Default Build with SWC (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary huozhi/next.js remove-pocess-usage-from-polyfill Change
buildDuration 25.2s 25.6s ⚠️ +424ms
buildDurationCached 8.5s 8.7s ⚠️ +182ms
nodeModulesSize 479 MB 479 MB -169 B
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js remove-pocess-usage-from-polyfill Change
/ failed reqs 0 0
/ total time (seconds) 5.791 5.737 -0.05
/ avg req/sec 431.69 435.75 +4.06
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.198 2.14 -0.06
/error-in-render avg req/sec 1137.31 1168.2 +30.89
Client Bundles (main, webpack)
vercel/next.js canary huozhi/next.js remove-pocess-usage-from-polyfill Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.7 kB 42.7 kB
main-HASH.js gzip 29.7 kB 29.7 kB
webpack-HASH.js gzip 1.54 kB 1.54 kB
Overall change 74.1 kB 74.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js remove-pocess-usage-from-polyfill Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js remove-pocess-usage-from-polyfill Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 311 B 311 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.89 kB 2.89 kB
head-HASH.js gzip 357 B 357 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.82 kB 5.82 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.78 kB 2.78 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.3 kB 16.3 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js remove-pocess-usage-from-polyfill Change
_buildManifest.js gzip 457 B 457 B
Overall change 457 B 457 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js remove-pocess-usage-from-polyfill Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB
Commit: 6fb4da7

@huozhi huozhi marked this pull request as ready for review May 23, 2022 17:16
packages/next/taskfile.js Outdated Show resolved Hide resolved
Co-authored-by: JJ Kasper <jj@jjsweb.site>
@kodiakhq kodiakhq bot merged commit fc06fe6 into vercel:canary May 23, 2022
@huozhi huozhi deleted the remove-pocess-usage-from-polyfill branch May 23, 2022 19:01
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants