perf: run type check and eslint in parallel

[SukkaW]

Feature

• Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
• Related issues linked using fixes #number
• Integration tests added
• Documentation added
• Telemetry added. In case of a feature if it's used or not.
• Errors have helpful link attached, see contributing.md

Implements #37088, fixes #36918.

[ijjk]

Stats from current PR

Default Build (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	SukkaW/next.js ts-check-worker	Change
buildDuration	18.9s	19.1s	⚠️ +221ms
buildDurationCached	7.5s	7.8s	⚠️ +318ms
nodeModulesSize	479 MB	479 MB	⚠️ +3.88 kB

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	SukkaW/next.js ts-check-worker	Change
/ failed reqs	0	0	✓
/ total time (seconds)	4.746	4.792	⚠️ +0.05
/ avg req/sec	526.8	521.75	⚠️ -5.05
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.618	1.639	⚠️ +0.02
/error-in-render avg req/sec	1545.03	1525.59	⚠️ -19.44

Client Bundles (main, webpack)

	vercel/next.js canary	SukkaW/next.js ts-check-worker	Change
925.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42 kB	42 kB	✓
main-HASH.js gzip	29.2 kB	29.2 kB	✓
webpack-HASH.js gzip	1.54 kB	1.54 kB	✓
Overall change	73 kB	73 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	SukkaW/next.js ts-check-worker	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	SukkaW/next.js ts-check-worker	Change
_app-HASH.js gzip	1.36 kB	1.36 kB	✓
_error-HASH.js gzip	193 B	193 B	✓
amp-HASH.js gzip	308 B	308 B	✓
css-HASH.js gzip	327 B	327 B	✓
dynamic-HASH.js gzip	2.71 kB	2.71 kB	✓
head-HASH.js gzip	359 B	359 B	✓
hooks-HASH.js gzip	920 B	920 B	✓
image-HASH.js gzip	5.73 kB	5.73 kB	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	2.65 kB	2.65 kB	✓
routerDirect..HASH.js gzip	320 B	320 B	✓
script-HASH.js gzip	391 B	391 B	✓
withRouter-HASH.js gzip	318 B	318 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	16 kB	16 kB	✓

Client Build Manifests

	vercel/next.js canary	SukkaW/next.js ts-check-worker	Change
_buildManifest.js gzip	458 B	458 B	✓
Overall change	458 B	458 B	✓

Rendered Page Sizes

	vercel/next.js canary	SukkaW/next.js ts-check-worker	Change
index.html gzip	533 B	533 B	✓
link.html gzip	547 B	547 B	✓
withRouter.html gzip	528 B	528 B	✓
Overall change	1.61 kB	1.61 kB	✓

---

Default Build with SWC (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	SukkaW/next.js ts-check-worker	Change
buildDuration	21.1s	21.4s	⚠️ +256ms
buildDurationCached	7.8s	7.6s	-132ms
nodeModulesSize	479 MB	479 MB	⚠️ +3.88 kB

Page Load Tests Overall increase ✓

	vercel/next.js canary	SukkaW/next.js ts-check-worker	Change
/ failed reqs	0	0	✓
/ total time (seconds)	4.726	4.681	-0.04
/ avg req/sec	528.99	534.03	+5.04
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.674	1.635	-0.04
/error-in-render avg req/sec	1493.31	1528.79	+35.48

Client Bundles (main, webpack)

	vercel/next.js canary	SukkaW/next.js ts-check-worker	Change
925.HASH.js gzip	178 B	178 B	✓
framework-HASH.js gzip	42.7 kB	42.7 kB	✓
main-HASH.js gzip	29.7 kB	29.7 kB	✓
webpack-HASH.js gzip	1.54 kB	1.54 kB	✓
Overall change	74.1 kB	74.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	SukkaW/next.js ts-check-worker	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	SukkaW/next.js ts-check-worker	Change
_app-HASH.js gzip	1.35 kB	1.35 kB	✓
_error-HASH.js gzip	179 B	179 B	✓
amp-HASH.js gzip	311 B	311 B	✓
css-HASH.js gzip	324 B	324 B	✓
dynamic-HASH.js gzip	2.89 kB	2.89 kB	✓
head-HASH.js gzip	357 B	357 B	✓
hooks-HASH.js gzip	920 B	920 B	✓
image-HASH.js gzip	5.82 kB	5.82 kB	✓
index-HASH.js gzip	261 B	261 B	✓
link-HASH.js gzip	2.78 kB	2.78 kB	✓
routerDirect..HASH.js gzip	322 B	322 B	✓
script-HASH.js gzip	392 B	392 B	✓
withRouter-HASH.js gzip	317 B	317 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	16.3 kB	16.3 kB	✓

Client Build Manifests

	vercel/next.js canary	SukkaW/next.js ts-check-worker	Change
_buildManifest.js gzip	457 B	457 B	✓
Overall change	457 B	457 B	✓

Rendered Page Sizes

	vercel/next.js canary	SukkaW/next.js ts-check-worker	Change
index.html gzip	531 B	531 B	✓
link.html gzip	546 B	546 B	✓
withRouter.html gzip	527 B	527 B	✓
Overall change	1.6 kB	1.6 kB	✓

Commit: 2ec070d

[ijjk]

Since we are grouping these together now should we update the spinner to mention when both are running and wait to stop it until both are finished?

[SukkaW]

Sounds a good idea, but the status message might be a little complex:

      let typeCheckingAndLintingSpinnerPrefixText = Log.prefixes.info + ' ';
      if (ignoreTypeScriptErrors && shouldLint) {
        typeCheckingAndLintingSpinnerPrefixText += 'Linting and skipping validation of types'
      } else if (!ignoreTypeScriptErrors && shouldLint) {
        typeCheckingAndLintingSpinnerPrefixText += 'Linting and checking validity of types'
      } else if (ignoreTypeScriptErrors && !shouldLint) {
        typeCheckingAndLintingSpinnerPrefixText += 'Skipping lint and validation of types'
      } else {
        typeCheckingAndLintingSpinnerPrefixText += 'Skipping lint and checking validity of types'
      }

Any suggestions about the message?

[ijjk]

The message could be something like:

if (!ignoreTypeScript && shouldLint) {
  text = 'Linting and checking validity of types'
} else if (!ignoreTypeScript) {
  text = 'Checking validity of types'
} else if (shouldLint) {
  text = 'Linting'
}

And then we could log the Skipped linting or Skipped checking validation of types separately maybe

[SukkaW]

Done in f6289ae (#37105)