Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure hydration error doc link is shown with react 18 #37074

Merged
merged 3 commits into from
May 20, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented May 20, 2022

Follow-up to #31519 this ensures the error link we added is shown with react 18 as well.

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels May 20, 2022
@ijjk
Copy link
Member Author

ijjk commented May 20, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/hydration-link Change
buildDuration 15.5s 15.5s ⚠️ +58ms
buildDurationCached 6.4s 6.2s -185ms
nodeModulesSize 479 MB 479 MB ⚠️ +180 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js update/hydration-link Change
/ failed reqs 0 0
/ total time (seconds) 3.767 3.743 -0.02
/ avg req/sec 663.69 667.91 +4.22
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.183 1.18 0
/error-in-render avg req/sec 2112.49 2118.77 +6.28
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js update/hydration-link Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 29 kB 29 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.6 kB 72.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/hydration-link Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/hydration-link Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 308 B 308 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.71 kB 2.71 kB
head-HASH.js gzip 359 B 359 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.73 kB 5.73 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.65 kB 2.65 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 391 B 391 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16 kB 16 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/hydration-link Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/hydration-link Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/hydration-link Change
buildDuration 17.7s 17.8s ⚠️ +66ms
buildDurationCached 6.2s 6.2s ⚠️ +9ms
nodeModulesSize 479 MB 479 MB ⚠️ +180 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/hydration-link Change
/ failed reqs 0 0
/ total time (seconds) 3.733 3.735 0
/ avg req/sec 669.63 669.42 ⚠️ -0.21
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.155 1.162 ⚠️ +0.01
/error-in-render avg req/sec 2164.13 2151.49 ⚠️ -12.64
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js update/hydration-link Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.7 kB 42.7 kB
main-HASH.js gzip 29.4 kB 29.4 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 73.7 kB 73.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/hydration-link Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/hydration-link Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 311 B 311 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.89 kB 2.89 kB
head-HASH.js gzip 357 B 357 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.82 kB 5.82 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.78 kB 2.78 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.3 kB 16.3 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/hydration-link Change
_buildManifest.js gzip 457 B 457 B
Overall change 457 B 457 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/hydration-link Change
index.html gzip 532 B 532 B
link.html gzip 547 B 547 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB
Commit: 42e883e

@ijjk ijjk marked this pull request as ready for review May 20, 2022 18:10
@kodiakhq kodiakhq bot merged commit 6e40fbd into vercel:canary May 20, 2022
@ijjk ijjk deleted the update/hydration-link branch May 20, 2022 20:23
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants