Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update a couple flakey tests #37071

Merged
merged 1 commit into from
May 20, 2022
Merged

Update a couple flakey tests #37071

merged 1 commit into from
May 20, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented May 20, 2022

The pnpm and next info tests seem to still flake occasionally but aren't signaling actual failures so this tweaks them to be more stable.

x-ref: https://github.com/vercel/next.js/runs/6515899829?check_suite_focus=true
x-ref: https://github.com/vercel/next.js/runs/6515899684?check_suite_focus=true
x-ref: https://github.com/vercel/next.js/runs/6524725633?check_suite_focus=true
x-ref: #37047

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team. label May 20, 2022
@ijjk
Copy link
Member Author

ijjk commented May 20, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary ijjk/next.js update/tests Change
buildDuration 18.4s 19s ⚠️ +605ms
buildDurationCached 7.4s 7.4s -39ms
nodeModulesSize 479 MB 479 MB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js update/tests Change
/ failed reqs 0 0
/ total time (seconds) 4.608 4.581 -0.03
/ avg req/sec 542.5 545.69 +3.19
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.582 1.565 -0.02
/error-in-render avg req/sec 1579.94 1597.74 +17.8
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js update/tests Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 29 kB 29 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.6 kB 72.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/tests Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/tests Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 308 B 308 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.71 kB 2.71 kB
head-HASH.js gzip 359 B 359 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.73 kB 5.73 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.65 kB 2.65 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 391 B 391 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16 kB 16 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/tests Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/tests Change
index.html gzip 533 B 533 B
link.html gzip 547 B 547 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB

Default Build with SWC (Increase detected ⚠️)
General
vercel/next.js canary ijjk/next.js update/tests Change
buildDuration 20.9s 20.8s -151ms
buildDurationCached 7.5s 7.4s -32ms
nodeModulesSize 479 MB 479 MB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js update/tests Change
/ failed reqs 0 0
/ total time (seconds) 4.651 4.66 ⚠️ +0.01
/ avg req/sec 537.48 536.52 ⚠️ -0.96
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.626 1.543 -0.08
/error-in-render avg req/sec 1537.9 1620.23 +82.33
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js update/tests Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.7 kB 42.7 kB
main-HASH.js gzip 29.5 kB 29.5 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 73.8 kB 73.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/tests Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/tests Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 311 B 311 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.89 kB 2.89 kB
head-HASH.js gzip 357 B 357 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.82 kB 5.82 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.78 kB 2.78 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.3 kB 16.3 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/tests Change
_buildManifest.js gzip 457 B 457 B
Overall change 457 B 457 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/tests Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB
Commit: 859bd98

@ijjk ijjk marked this pull request as ready for review May 20, 2022 17:05
@ijjk ijjk merged commit 5af2fbb into vercel:canary May 20, 2022
@ijjk ijjk deleted the update/tests branch May 20, 2022 17:44
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants