Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix styled-jsx not working in client components in the edge runtime when SSR #37042

Merged
merged 2 commits into from
May 19, 2022

Conversation

shuding
Copy link
Member

@shuding shuding commented May 19, 2022

The Edge SSR server and the client bundle should share the same Styled JSX instance to ensure the context can be passed correctly, same with the way we handle next/head.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels May 19, 2022
@shuding shuding marked this pull request as ready for review May 19, 2022 16:08
@ijjk
Copy link
Member

ijjk commented May 19, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js shu/6b94 Change
buildDuration 16.4s 16.3s -120ms
buildDurationCached 6.4s 6.3s -92ms
nodeModulesSize 478 MB 478 MB ⚠️ +54 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js shu/6b94 Change
/ failed reqs 0 0
/ total time (seconds) 3.935 4.05 ⚠️ +0.11
/ avg req/sec 635.38 617.34 ⚠️ -18.04
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.385 1.459 ⚠️ +0.07
/error-in-render avg req/sec 1804.61 1713.7 ⚠️ -90.91
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js shu/6b94 Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 29 kB 29 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.6 kB 72.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js shu/6b94 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js shu/6b94 Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 308 B 308 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.71 kB 2.71 kB
head-HASH.js gzip 359 B 359 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.73 kB 5.73 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.65 kB 2.65 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 391 B 391 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16 kB 16 kB
Client Build Manifests
vercel/next.js canary vercel/next.js shu/6b94 Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js shu/6b94 Change
index.html gzip 531 B 531 B
link.html gzip 544 B 544 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js shu/6b94 Change
buildDuration 18.8s 18.8s ⚠️ +14ms
buildDurationCached 6.3s 6.4s ⚠️ +36ms
nodeModulesSize 478 MB 478 MB ⚠️ +54 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js shu/6b94 Change
/ failed reqs 0 0
/ total time (seconds) 4.048 4.027 -0.02
/ avg req/sec 617.6 620.77 +3.17
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.388 1.432 ⚠️ +0.04
/error-in-render avg req/sec 1801.67 1746.25 ⚠️ -55.42
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js shu/6b94 Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.7 kB 42.7 kB
main-HASH.js gzip 29.5 kB 29.5 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 73.8 kB 73.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js shu/6b94 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js shu/6b94 Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 311 B 311 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.89 kB 2.89 kB
head-HASH.js gzip 357 B 357 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.82 kB 5.82 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.78 kB 2.78 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.3 kB 16.3 kB
Client Build Manifests
vercel/next.js canary vercel/next.js shu/6b94 Change
_buildManifest.js gzip 457 B 457 B
Overall change 457 B 457 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js shu/6b94 Change
index.html gzip 531 B 531 B
link.html gzip 546 B 546 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB
Commit: 5c2c170

@kodiakhq kodiakhq bot merged commit cd6b491 into canary May 19, 2022
@kodiakhq kodiakhq bot deleted the shu/6b94 branch May 19, 2022 16:44
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants