Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest version of @vercel/nft #37041

Merged
merged 2 commits into from
May 19, 2022
Merged

Update to latest version of @vercel/nft #37041

merged 2 commits into from
May 19, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented May 19, 2022

This includes some fixes for node: prefix and node-gyp-build

x-ref: https://github.com/vercel/nft/releases/tag/0.19.0

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels May 19, 2022
@ijjk ijjk marked this pull request as ready for review May 19, 2022 16:17
@ijjk
Copy link
Member Author

ijjk commented May 19, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/nft Change
buildDuration 17s 18s ⚠️ +1s
buildDurationCached 6.9s 6.8s -59ms
nodeModulesSize 478 MB 478 MB ⚠️ +176 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/nft Change
/ failed reqs 0 0
/ total time (seconds) 4.296 4.38 ⚠️ +0.08
/ avg req/sec 581.9 570.77 ⚠️ -11.13
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.473 1.521 ⚠️ +0.05
/error-in-render avg req/sec 1697.19 1643.19 ⚠️ -54
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js update/nft Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 29 kB 29 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.6 kB 72.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/nft Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/nft Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 308 B 308 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.71 kB 2.71 kB
head-HASH.js gzip 359 B 359 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.73 kB 5.73 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.65 kB 2.65 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 391 B 391 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16 kB 16 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/nft Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/nft Change
index.html gzip 531 B 531 B
link.html gzip 544 B 544 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/nft Change
buildDuration 19.6s 19.7s ⚠️ +125ms
buildDurationCached 7s 6.9s -80ms
nodeModulesSize 478 MB 478 MB ⚠️ +176 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js update/nft Change
/ failed reqs 0 0
/ total time (seconds) 4.324 4.248 -0.08
/ avg req/sec 578.18 588.46 +10.28
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.521 1.484 -0.04
/error-in-render avg req/sec 1643.96 1684.14 +40.18
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js update/nft Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.7 kB 42.7 kB
main-HASH.js gzip 29.5 kB 29.5 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 73.8 kB 73.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/nft Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/nft Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 311 B 311 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.89 kB 2.89 kB
head-HASH.js gzip 357 B 357 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.82 kB 5.82 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.78 kB 2.78 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.3 kB 16.3 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/nft Change
_buildManifest.js gzip 457 B 457 B
Overall change 457 B 457 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/nft Change
index.html gzip 531 B 531 B
link.html gzip 546 B 546 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB
Commit: 90b5e27

@ijjk ijjk requested a review from styfle May 19, 2022 16:23
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ijjk ijjk merged commit 947bcd8 into vercel:canary May 19, 2022
@ijjk ijjk deleted the update/nft branch May 19, 2022 16:59
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants