Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DecodeError from invalid URI causes 500 with middleware (vs 400 without) #36993

Merged
merged 5 commits into from
May 22, 2022
Merged

DecodeError from invalid URI causes 500 with middleware (vs 400 without) #36993

merged 5 commits into from
May 22, 2022

Conversation

FLCN-16
Copy link
Contributor

@FLCN-16 FLCN-16 commented May 17, 2022

Bug

  • Related issues linked using fixes #36964
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Fixes: #36964
Fixes: #37025

@ijjk
Copy link
Member

ijjk commented May 22, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary FLCN-16/next.js fix/invalid-uri-error Change
buildDuration 14.6s 14.4s -140ms
buildDurationCached 5.8s 5.9s ⚠️ +88ms
nodeModulesSize 479 MB 479 MB ⚠️ +741 B
Page Load Tests Overall increase ✓
vercel/next.js canary FLCN-16/next.js fix/invalid-uri-error Change
/ failed reqs 0 0
/ total time (seconds) 3.563 3.553 -0.01
/ avg req/sec 701.62 703.65 +2.03
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.243 1.236 -0.01
/error-in-render avg req/sec 2010.76 2022.3 +11.54
Client Bundles (main, webpack)
vercel/next.js canary FLCN-16/next.js fix/invalid-uri-error Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 29 kB 29 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.6 kB 72.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary FLCN-16/next.js fix/invalid-uri-error Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary FLCN-16/next.js fix/invalid-uri-error Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 308 B 308 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.71 kB 2.71 kB
head-HASH.js gzip 359 B 359 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.73 kB 5.73 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.65 kB 2.65 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 391 B 391 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16 kB 16 kB
Client Build Manifests
vercel/next.js canary FLCN-16/next.js fix/invalid-uri-error Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary FLCN-16/next.js fix/invalid-uri-error Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary FLCN-16/next.js fix/invalid-uri-error Change
buildDuration 16.3s 16.6s ⚠️ +295ms
buildDurationCached 5.9s 6.1s ⚠️ +257ms
nodeModulesSize 479 MB 479 MB ⚠️ +741 B
Page Load Tests Overall increase ✓
vercel/next.js canary FLCN-16/next.js fix/invalid-uri-error Change
/ failed reqs 0 0
/ total time (seconds) 3.564 3.57 ⚠️ +0.01
/ avg req/sec 701.49 700.27 ⚠️ -1.22
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.296 1.248 -0.05
/error-in-render avg req/sec 1928.69 2003.9 +75.21
Client Bundles (main, webpack)
vercel/next.js canary FLCN-16/next.js fix/invalid-uri-error Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.7 kB 42.7 kB
main-HASH.js gzip 29.4 kB 29.4 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 73.7 kB 73.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary FLCN-16/next.js fix/invalid-uri-error Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary FLCN-16/next.js fix/invalid-uri-error Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 311 B 311 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.89 kB 2.89 kB
head-HASH.js gzip 357 B 357 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.82 kB 5.82 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.78 kB 2.78 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.3 kB 16.3 kB
Client Build Manifests
vercel/next.js canary FLCN-16/next.js fix/invalid-uri-error Change
_buildManifest.js gzip 457 B 457 B
Overall change 457 B 457 B
Rendered Page Sizes
vercel/next.js canary FLCN-16/next.js fix/invalid-uri-error Change
index.html gzip 532 B 532 B
link.html gzip 547 B 547 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB
Commit: 56eb1ec

Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@ijjk ijjk merged commit 7e57432 into vercel:canary May 22, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants