Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove optional chaining from eslint rule to support older node versions #36978

Merged
merged 2 commits into from
May 17, 2022

Conversation

hanneslund
Copy link
Contributor

@hanneslund hanneslund commented May 17, 2022

fixes #36693

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

@ijjk
Copy link
Member

ijjk commented May 17, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General
vercel/next.js canary hanneslund/next.js issue-36693 Change
buildDuration 15.6s 14.9s -727ms
buildDurationCached 6.2s 6.3s ⚠️ +64ms
nodeModulesSize 478 MB 478 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary hanneslund/next.js issue-36693 Change
/ failed reqs 0 0
/ total time (seconds) 3.86 3.902 ⚠️ +0.04
/ avg req/sec 647.59 640.77 ⚠️ -6.82
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.322 1.348 ⚠️ +0.03
/error-in-render avg req/sec 1891.28 1854.83 ⚠️ -36.45
Client Bundles (main, webpack)
vercel/next.js canary hanneslund/next.js issue-36693 Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.7 kB 28.7 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.4 kB 72.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary hanneslund/next.js issue-36693 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary hanneslund/next.js issue-36693 Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 308 B 308 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.7 kB 2.7 kB
head-HASH.js gzip 359 B 359 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.71 kB 5.71 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.65 kB 2.65 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 391 B 391 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.9 kB 15.9 kB
Client Build Manifests
vercel/next.js canary hanneslund/next.js issue-36693 Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary hanneslund/next.js issue-36693 Change
index.html gzip 532 B 532 B
link.html gzip 544 B 544 B
withRouter.html gzip 528 B 528 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General
vercel/next.js canary hanneslund/next.js issue-36693 Change
buildDuration 17.8s 17.9s ⚠️ +80ms
buildDurationCached 6.1s 6.4s ⚠️ +227ms
nodeModulesSize 478 MB 478 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary hanneslund/next.js issue-36693 Change
/ failed reqs 0 0
/ total time (seconds) 3.867 3.974 ⚠️ +0.11
/ avg req/sec 646.45 629.13 ⚠️ -17.32
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.346 1.407 ⚠️ +0.06
/error-in-render avg req/sec 1857.42 1776.46 ⚠️ -80.96
Client Bundles (main, webpack)
vercel/next.js canary hanneslund/next.js issue-36693 Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.7 kB 42.7 kB
main-HASH.js gzip 29.2 kB 29.2 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 73.5 kB 73.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary hanneslund/next.js issue-36693 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary hanneslund/next.js issue-36693 Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 311 B 311 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.89 kB 2.89 kB
head-HASH.js gzip 357 B 357 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.8 kB 5.8 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.77 kB 2.77 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.3 kB 16.3 kB
Client Build Manifests
vercel/next.js canary hanneslund/next.js issue-36693 Change
_buildManifest.js gzip 457 B 457 B
Overall change 457 B 457 B
Rendered Page Sizes
vercel/next.js canary hanneslund/next.js issue-36693 Change
index.html gzip 532 B 532 B
link.html gzip 547 B 547 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB
Commit: a5392e7

@kodiakhq kodiakhq bot merged commit 4fd883f into vercel:canary May 17, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2022
@hanneslund hanneslund deleted the issue-36693 branch September 8, 2022 06:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESLint Error During Vercel Deployment
3 participants