Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: clean up duplicated tests #36871

Merged
merged 1 commit into from
May 13, 2022
Merged

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented May 12, 2022

Clean up integration tests

  • app-document: Merge multi fetch reuqests into 1, add checking for __NEXT_DATA__
  • rsc/streaming: Merge duplicated tests, move the head tests to client-navigation since they're running under react 18 now
  • remove runtime subtest suite under rsc tests since it's covered in switchable runtime test suite

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team. label May 12, 2022
@ijjk
Copy link
Member

ijjk commented May 12, 2022

Failing test suites

Commit: 070628e

yarn testheadless test/integration/react-18-invalid-config/index.test.js

  • Invalid custom document with gip prod > should support api routes
Expand output

● Invalid custom document with gip prod › should support api routes

FetchError: request to http://localhost:43441/api/ping failed, reason: socket hang up

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1491:11)

Read more about building and testing Next.js in contributing.md.

@huozhi huozhi marked this pull request as ready for review May 12, 2022 19:46
@ijjk
Copy link
Member

ijjk commented May 12, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary huozhi/next.js test/clean-up Change
buildDuration 15.5s 15.6s ⚠️ +80ms
buildDurationCached 6.2s 6.3s ⚠️ +54ms
nodeModulesSize 475 MB 475 MB
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js test/clean-up Change
/ failed reqs 0 0
/ total time (seconds) 3.83 3.801 -0.03
/ avg req/sec 652.79 657.78 +4.99
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.178 1.17 -0.01
/error-in-render avg req/sec 2121.75 2136.82 +15.07
Client Bundles (main, webpack)
vercel/next.js canary huozhi/next.js test/clean-up Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.8 kB 28.8 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js test/clean-up Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js test/clean-up Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 308 B 308 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.69 kB 2.69 kB
head-HASH.js gzip 359 B 359 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.7 kB 5.7 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.64 kB 2.64 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 391 B 391 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.9 kB 15.9 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js test/clean-up Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js test/clean-up Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General
vercel/next.js canary huozhi/next.js test/clean-up Change
buildDuration 17.6s 17.5s -104ms
buildDurationCached 6.2s 6.2s -33ms
nodeModulesSize 475 MB 475 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js test/clean-up Change
/ failed reqs 0 0
/ total time (seconds) 3.79 3.809 ⚠️ +0.02
/ avg req/sec 659.66 656.3 ⚠️ -3.36
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.133 1.191 ⚠️ +0.06
/error-in-render avg req/sec 2206.79 2098.31 ⚠️ -108.48
Client Bundles (main, webpack)
vercel/next.js canary huozhi/next.js test/clean-up Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 29.2 kB 29.2 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 73.1 kB 73.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js test/clean-up Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js test/clean-up Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.71 kB 2.71 kB
head-HASH.js gzip 357 B 357 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.79 kB 5.79 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.76 kB 2.76 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.1 kB 16.1 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js test/clean-up Change
_buildManifest.js gzip 456 B 456 B
Overall change 456 B 456 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js test/clean-up Change
index.html gzip 530 B 530 B
link.html gzip 543 B 543 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB
Commit: 03a0afe

@kodiakhq kodiakhq bot merged commit 092346d into vercel:canary May 13, 2022
@huozhi huozhi deleted the test/clean-up branch May 13, 2022 09:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants