Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move FlightManifestPlugin to server compilers #36810

Merged
merged 5 commits into from
May 10, 2022
Merged

Conversation

shuding
Copy link
Member

@shuding shuding commented May 10, 2022

Extracted from #36524, this PR moves FlightManifestPlugin to (Node.js/Edge) server compilers.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk
Copy link
Member

ijjk commented May 10, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary shuding/next.js shu/b98a Change
buildDuration 16.3s 16.3s ⚠️ +44ms
buildDurationCached 6.4s 6.4s ⚠️ +10ms
nodeModulesSize 475 MB 475 MB -9 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary shuding/next.js shu/b98a Change
/ failed reqs 0 0
/ total time (seconds) 3.918 3.96 ⚠️ +0.04
/ avg req/sec 638.02 631.28 ⚠️ -6.74
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.246 1.262 ⚠️ +0.02
/error-in-render avg req/sec 2006.67 1981.31 ⚠️ -25.36
Client Bundles (main, webpack)
vercel/next.js canary shuding/next.js shu/b98a Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.8 kB 28.8 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/b98a Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary shuding/next.js shu/b98a Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 308 B 308 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.69 kB 2.69 kB
head-HASH.js gzip 359 B 359 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.7 kB 5.7 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.64 kB 2.64 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 391 B 391 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.9 kB 15.9 kB
Client Build Manifests
vercel/next.js canary shuding/next.js shu/b98a Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/b98a Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB

Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary shuding/next.js shu/b98a Change
buildDuration 18.5s 18.4s -72ms
buildDurationCached 6.5s 6.3s -172ms
nodeModulesSize 475 MB 475 MB -9 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary shuding/next.js shu/b98a Change
/ failed reqs 0 0
/ total time (seconds) 3.917 4.001 ⚠️ +0.08
/ avg req/sec 638.17 624.84 ⚠️ -13.33
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.255 1.357 ⚠️ +0.1
/error-in-render avg req/sec 1991.61 1841.73 ⚠️ -149.88
Client Bundles (main, webpack)
vercel/next.js canary shuding/next.js shu/b98a Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 29.2 kB 29.2 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 73.1 kB 73.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/b98a Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary shuding/next.js shu/b98a Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.71 kB 2.71 kB
head-HASH.js gzip 357 B 357 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.79 kB 5.79 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.76 kB 2.76 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.1 kB 16.1 kB
Client Build Manifests
vercel/next.js canary shuding/next.js shu/b98a Change
_buildManifest.js gzip 456 B 456 B
Overall change 456 B 456 B
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/b98a Change
index.html gzip 529 B 529 B
link.html gzip 543 B 543 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: 1997de2

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels May 10, 2022
timneutkens
timneutkens previously approved these changes May 10, 2022
@shuding shuding merged commit fdc071c into vercel:canary May 10, 2022
@shuding shuding deleted the shu/b98a branch May 10, 2022 19:20
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants