Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove invalid attrs for head html element #36457

Merged
merged 3 commits into from
May 22, 2022

Conversation

ykolbin
Copy link
Contributor

@ykolbin ykolbin commented Apr 25, 2022

fixes #36456

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

@ykolbin
Copy link
Contributor Author

ykolbin commented Apr 25, 2022

I reused existing integration tests, because they won't pass amp validation via await validateAMP(html), if nonce or crossOrigin are present

@ykolbin
Copy link
Contributor Author

ykolbin commented May 10, 2022

Hi @timneutkens, @ijjk, @shuding, @huozhi,

Sorry that I'm bother you, will you have time to review changes anytime soon?

Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ijjk
Copy link
Member

ijjk commented May 22, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ykolbin/next.js fix-invalid-head-attr Change
buildDuration 14.3s 15.1s ⚠️ +743ms
buildDurationCached 6s 6.6s ⚠️ +588ms
nodeModulesSize 479 MB 479 MB ⚠️ +615 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ykolbin/next.js fix-invalid-head-attr Change
/ failed reqs 0 0
/ total time (seconds) 3.641 4.182 ⚠️ +0.54
/ avg req/sec 686.56 597.73 ⚠️ -88.83
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.264 1.508 ⚠️ +0.24
/error-in-render avg req/sec 1977.7 1658.03 ⚠️ -319.67
Client Bundles (main, webpack)
vercel/next.js canary ykolbin/next.js fix-invalid-head-attr Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 29 kB 29 kB
webpack-HASH.js gzip 1.54 kB 1.54 kB
Overall change 72.7 kB 72.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ykolbin/next.js fix-invalid-head-attr Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ykolbin/next.js fix-invalid-head-attr Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 308 B 308 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.71 kB 2.71 kB
head-HASH.js gzip 359 B 359 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.73 kB 5.73 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.65 kB 2.65 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 391 B 391 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16 kB 16 kB
Client Build Manifests
vercel/next.js canary ykolbin/next.js fix-invalid-head-attr Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary ykolbin/next.js fix-invalid-head-attr Change
index.html gzip 533 B 533 B
link.html gzip 547 B 547 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ykolbin/next.js fix-invalid-head-attr Change
buildDuration 17.2s 16.2s -1s
buildDurationCached 6s 5.9s -35ms
nodeModulesSize 479 MB 479 MB ⚠️ +615 B
Page Load Tests Overall increase ✓
vercel/next.js canary ykolbin/next.js fix-invalid-head-attr Change
/ failed reqs 0 0
/ total time (seconds) 3.717 3.635 -0.08
/ avg req/sec 672.64 687.82 +15.18
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.297 1.292 0
/error-in-render avg req/sec 1928.21 1934.87 +6.66
Client Bundles (main, webpack)
vercel/next.js canary ykolbin/next.js fix-invalid-head-attr Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.7 kB 42.7 kB
main-HASH.js gzip 29.5 kB 29.5 kB
webpack-HASH.js gzip 1.54 kB 1.54 kB
Overall change 73.9 kB 73.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ykolbin/next.js fix-invalid-head-attr Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ykolbin/next.js fix-invalid-head-attr Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 311 B 311 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.89 kB 2.89 kB
head-HASH.js gzip 357 B 357 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.82 kB 5.82 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.78 kB 2.78 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.3 kB 16.3 kB
Client Build Manifests
vercel/next.js canary ykolbin/next.js fix-invalid-head-attr Change
_buildManifest.js gzip 457 B 457 B
Overall change 457 B 457 B
Rendered Page Sizes
vercel/next.js canary ykolbin/next.js fix-invalid-head-attr Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB
Commit: a0bfdc3

@ijjk ijjk merged commit 29b3cdf into vercel:canary May 22, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid head attributes in amp mode
2 participants