Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge multiple log statements #35310

Merged
merged 5 commits into from
May 22, 2022
Merged

Merge multiple log statements #35310

merged 5 commits into from
May 22, 2022

Conversation

Exortions
Copy link
Contributor

@Exortions Exortions commented Mar 14, 2022

It is inefficient to use multiple console.log satements, and if something is logged to the console in the middle of execution, it will be in the center of the text, making it hard to read.
This pull request merges multiple console.logs into one.

In addition, it reduces the bundle size.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

It is inefficient to use multiple console.log satements, and if something is logged to the console in the middle of execution, it will be in the center of the text, making it hard to read.
This pull request merges multiple console.logs into one.

In addition, it reduces the bundle size.
@ijjk ijjk added the create-next-app Related to our CLI tool for quickly starting a new Next.js application. label Mar 14, 2022
Comment on lines 94 to 95
Please specify the project directory:
${chalk.cyan(program.name())} ${chalk.green('<project-directory>')}
Copy link
Contributor

@kachkaev kachkaev Mar 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These lines will print with a pretty long offset. Using @` instead of ` might help in the future:
https://github.com/tc39/proposal-string-dedent

Might be worth leaving as is for now.

ijjk
ijjk previously approved these changes May 22, 2022
@ijjk
Copy link
Member

ijjk commented May 22, 2022

Failing test suites

Commit: c96de50

yarn testheadless test/integration/client-navigation/test/index.test.js

  • Client Navigation > should navigate to paths relative to the current page
Expand output

● Client Navigation › should navigate to paths relative to the current page

page.waitForSelector: Timeout 500ms exceeded.
=========================== logs ===========================
waiting for selector "#relative-2"
  selector resolved to visible <div id="relative-2">…</div>
============================================================

  304 |     return this.chain(() => {
  305 |       return page
> 306 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  307 |         .then(async (el) => {
  308 |           // it seems selenium waits longer and tests rely on this behavior
  309 |           // so we wait for the load event fire before returning

  at lib/browsers/playwright.ts:306:10

Read more about building and testing Next.js in contributing.md.

@ijjk
Copy link
Member

ijjk commented May 22, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary Exortions/next.js patch-1 Change
buildDuration 20.8s 20.7s -125ms
buildDurationCached 8.2s 8.2s ⚠️ +3ms
nodeModulesSize 479 MB 479 MB
Page Load Tests Overall increase ✓
vercel/next.js canary Exortions/next.js patch-1 Change
/ failed reqs 0 0
/ total time (seconds) 5.57 5.64 ⚠️ +0.07
/ avg req/sec 448.83 443.26 ⚠️ -5.57
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.156 2.103 -0.05
/error-in-render avg req/sec 1159.44 1188.82 +29.38
Client Bundles (main, webpack)
vercel/next.js canary Exortions/next.js patch-1 Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 29.1 kB 29.1 kB
webpack-HASH.js gzip 1.54 kB 1.54 kB
Overall change 72.8 kB 72.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary Exortions/next.js patch-1 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary Exortions/next.js patch-1 Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 308 B 308 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.71 kB 2.71 kB
head-HASH.js gzip 359 B 359 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.73 kB 5.73 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.65 kB 2.65 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 391 B 391 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16 kB 16 kB
Client Build Manifests
vercel/next.js canary Exortions/next.js patch-1 Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary Exortions/next.js patch-1 Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General
vercel/next.js canary Exortions/next.js patch-1 Change
buildDuration 23.8s 24s ⚠️ +165ms
buildDurationCached 8.2s 8.1s -92ms
nodeModulesSize 479 MB 479 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Exortions/next.js patch-1 Change
/ failed reqs 0 0
/ total time (seconds) 5.501 5.575 ⚠️ +0.07
/ avg req/sec 454.45 448.39 ⚠️ -6.06
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.211 2.206 0
/error-in-render avg req/sec 1130.62 1133.47 +2.85
Client Bundles (main, webpack)
vercel/next.js canary Exortions/next.js patch-1 Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.7 kB 42.7 kB
main-HASH.js gzip 29.6 kB 29.6 kB
webpack-HASH.js gzip 1.54 kB 1.54 kB
Overall change 74 kB 74 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary Exortions/next.js patch-1 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary Exortions/next.js patch-1 Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 311 B 311 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.89 kB 2.89 kB
head-HASH.js gzip 357 B 357 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.82 kB 5.82 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.78 kB 2.78 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.3 kB 16.3 kB
Client Build Manifests
vercel/next.js canary Exortions/next.js patch-1 Change
_buildManifest.js gzip 457 B 457 B
Overall change 457 B 457 B
Rendered Page Sizes
vercel/next.js canary Exortions/next.js patch-1 Change
index.html gzip 532 B 532 B
link.html gzip 547 B 547 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB
Commit: c96de50

@ijjk ijjk merged commit ef69aca into vercel:canary May 22, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
create-next-app Related to our CLI tool for quickly starting a new Next.js application.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants