Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gh-pages example for windows user #35169

Merged
merged 3 commits into from
May 22, 2022
Merged

Fix gh-pages example for windows user #35169

merged 3 commits into from
May 22, 2022

Conversation

woochul2
Copy link
Contributor

@woochul2 woochul2 commented Mar 9, 2022

Windows users cannot use the rm and touch commands. So I replaced it with rimraf and touch package.

@ijjk ijjk added the examples Issue/PR related to examples label Mar 9, 2022
@ijjk ijjk requested a review from balazsorban44 as a code owner May 22, 2022 21:06
ijjk
ijjk approved these changes May 22, 2022
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kodiakhq kodiakhq bot merged commit f467bf2 into vercel:canary May 22, 2022
@woochul2 woochul2 deleted the fix-examples branch May 22, 2022 23:59
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@leerob leerob Awaiting requested review from leerob

@steven-tey steven-tey Awaiting requested review from steven-tey

@balazsorban44 balazsorban44 Awaiting requested review from balazsorban44

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@woochul2 @ijjk