Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example/facebook pixel script #34417

Merged
merged 11 commits into from
May 13, 2022

Conversation

lukeshumard
Copy link
Contributor

The with-facebook-pixel example attempts to run the <Script /> loading the Facebook Pixel on every request. This results in a warning stating [Meta Pixel] - Duplicate Pixel ID: xxx. According to the Next.js docs, by using an id on the inline script Next is able to track and optimize the script. Since this is absent on the present example, the inline script is continuously loaded on every request.

I've added an id to this inline script, and the warning from facebook is no longer present.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added the examples Issue/PR related to examples label Feb 16, 2022
@lukeshumard lukeshumard marked this pull request as ready for review February 16, 2022 16:46
Copy link

@Auta1994 Auta1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sani

@kodiakhq kodiakhq bot merged commit 2b88467 into vercel:canary May 13, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants