Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs about locale #33401

Merged
merged 7 commits into from
May 22, 2022
Merged

Add docs about locale #33401

merged 7 commits into from
May 22, 2022

Conversation

MaedahBatool
Copy link
Contributor

@MaedahBatool MaedahBatool commented Jan 17, 2022 •
edited by ijjk
Loading

Came across this Slack thread. Update the docs about adding locale string in getStaticPaths docs.

Feature

Documentation / Examples

  • Make sure the linting passes by running yarn lint

Closes: #32772

@MaedahBatool MaedahBatool self-assigned this Jan 17, 2022
@MaedahBatool
Copy link
Contributor Author

@balazsorban44, since you pointed this out. Please can you review this PR? Thank you :)

@MaedahBatool
Copy link
Contributor Author

Hi @balazsorban44 do we have any update around this PR? Is this still valid?

@kodiakhq kodiakhq bot merged commit 84cba20 into vercel:canary May 22, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nbouvrette nbouvrette nbouvrette left review comments

@leerob leerob leerob left review comments

@ijjk ijjk ijjk approved these changes

@huozhi huozhi Awaiting requested review from huozhi

@padmaia padmaia Awaiting requested review from padmaia

@shuding shuding Awaiting requested review from shuding

@styfle styfle Awaiting requested review from styfle

@timneutkens timneutkens Awaiting requested review from timneutkens

@balazsorban44 balazsorban44 Awaiting requested review from balazsorban44

Assignees

@MaedahBatool MaedahBatool

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with asPath when using getStaticProps and redirects
5 participants
@MaedahBatool @nbouvrette @leerob @balazsorban44 @ijjk