Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove node fetch polyfill from base server #33395

Merged
merged 3 commits into from
Jan 17, 2022
Merged

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Jan 17, 2022

  • keep fetch polyfill only in dev-server, next-server (polyfilled in next.ts)
  • also export worker, static paths worker since they also requires it

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next examples Issue/PR related to examples labels Jan 17, 2022
@huozhi huozhi force-pushed the bs/fetch branch 2 times, most recently from e4404f8 to 1d6b78e Compare January 17, 2022 13:09
@huozhi huozhi removed the examples Issue/PR related to examples label Jan 17, 2022
@ijjk

This comment has been minimized.

Copy link
Member

@shuding shuding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also export worker, static paths worker since they also requires it

I don't see that in the code, could you elaborate?

@shuding shuding linked an issue Jan 17, 2022 that may be closed by this pull request
15 tasks
@huozhi
Copy link
Member Author

huozhi commented Jan 17, 2022

also export worker, static paths worker since they also requires it

I don't see that in the code, could you elaborate?

static-paths-worker and export workers still keep the polyfill

@ijjk
Copy link
Member

ijjk commented Jan 17, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary huozhi/next.js bs/fetch Change
buildDuration 14.4s 14.4s -6ms
buildDurationCached 3.2s 3.2s -15ms
nodeModulesSize 352 MB 352 MB -226 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js bs/fetch Change
/ failed reqs 0 0
/ total time (seconds) 2.958 2.976 ⚠️ +0.02
/ avg req/sec 845.24 839.92 ⚠️ -5.32
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.37 1.367 0
/error-in-render avg req/sec 1824.62 1829.07 +4.45
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js bs/fetch Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27.2 kB 27.2 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71 kB 71 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js bs/fetch Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js bs/fetch Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 4.7 kB 4.7 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.13 kB 2.13 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.1 kB 14.1 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js bs/fetch Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js bs/fetch Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary huozhi/next.js bs/fetch Change
buildDuration 16s 15.4s -543ms
buildDurationCached 3.2s 3.2s ⚠️ +27ms
nodeModulesSize 352 MB 352 MB -226 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js bs/fetch Change
/ failed reqs 0 0
/ total time (seconds) 2.943 2.902 -0.04
/ avg req/sec 849.34 861.55 +12.21
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.314 1.333 ⚠️ +0.02
/error-in-render avg req/sec 1903.05 1874.79 ⚠️ -28.26
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js bs/fetch Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 27.3 kB 27.3 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.3 kB 71.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js bs/fetch Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js bs/fetch Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.36 kB 2.36 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 4.73 kB 4.73 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.19 kB 2.19 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.1 kB 14.1 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js bs/fetch Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js bs/fetch Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: 9b1ac6e

@kodiakhq kodiakhq bot merged commit 2c9c8f7 into vercel:canary Jan 17, 2022
kodiakhq bot pushed a commit to NOCELL/next.js that referenced this pull request Jan 17, 2022
* keep fetch polyfill only in dev-server, next-server (polyfilled in next.ts)
* also export worker, static paths worker since they also requires it
@huozhi huozhi deleted the bs/fetch branch January 17, 2022 16:05
natew pushed a commit to natew/next.js that referenced this pull request Feb 16, 2022
* keep fetch polyfill only in dev-server, next-server (polyfilled in next.ts)
* also export worker, static paths worker since they also requires it
natew pushed a commit to natew/next.js that referenced this pull request Feb 16, 2022
* keep fetch polyfill only in dev-server, next-server (polyfilled in next.ts)
* also export worker, static paths worker since they also requires it
@vercel vercel locked as resolved and limited conversation to collaborators Feb 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switchable server runtime
3 participants