Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace regexp to plain string for optimization render HTML #33306

Merged
merged 5 commits into from
Jan 17, 2022

Conversation

NOCELL
Copy link
Contributor

@NOCELL NOCELL commented Jan 14, 2022

Bug

Line const [renderTargetPrefix, renderTargetSuffix] = documentHTML.split(*) with RegExp almost 80 times slower than a plain string.

Before:
telegram-cloud-photo-size-2-5409140542421448593-y

After:
telegram-cloud-photo-size-2-5409140542421448594-y

Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

The PR will be auto-merged now so please don't click update branch as it'll stop that from happening 🙏

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Jan 17, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary NOCELL/next.js canary Change
buildDuration 17.2s 17.4s ⚠️ +173ms
buildDurationCached 3.9s 3.8s -19ms
nodeModulesSize 352 MB 352 MB ⚠️ +1 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary NOCELL/next.js canary Change
/ failed reqs 0 0
/ total time (seconds) 3.464 3.506 ⚠️ +0.04
/ avg req/sec 721.72 713.09 ⚠️ -8.63
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.584 1.675 ⚠️ +0.09
/error-in-render avg req/sec 1577.84 1492.91 ⚠️ -84.93
Client Bundles (main, webpack, commons)
vercel/next.js canary NOCELL/next.js canary Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27.2 kB 27.2 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71 kB 71 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary NOCELL/next.js canary Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary NOCELL/next.js canary Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 4.7 kB 4.7 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.13 kB 2.13 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.1 kB 14.1 kB
Client Build Manifests
vercel/next.js canary NOCELL/next.js canary Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary NOCELL/next.js canary Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary NOCELL/next.js canary Change
buildDuration 18.9s 18.9s ⚠️ +39ms
buildDurationCached 3.9s 3.8s -51ms
nodeModulesSize 352 MB 352 MB ⚠️ +1 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary NOCELL/next.js canary Change
/ failed reqs 0 0
/ total time (seconds) 3.537 3.527 -0.01
/ avg req/sec 706.76 708.84 +2.08
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.639 1.723 ⚠️ +0.08
/error-in-render avg req/sec 1525.69 1451.12 ⚠️ -74.57
Client Bundles (main, webpack, commons)
vercel/next.js canary NOCELL/next.js canary Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 27.3 kB 27.3 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.3 kB 71.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary NOCELL/next.js canary Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary NOCELL/next.js canary Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.36 kB 2.36 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 4.73 kB 4.73 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.19 kB 2.19 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.1 kB 14.1 kB
Client Build Manifests
vercel/next.js canary NOCELL/next.js canary Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary NOCELL/next.js canary Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: 6ab6b09

@kodiakhq kodiakhq bot merged commit 8dc4670 into vercel:canary Jan 17, 2022
natew pushed a commit to natew/next.js that referenced this pull request Feb 16, 2022
…3306)

## Bug

Line `const [renderTargetPrefix, renderTargetSuffix] = documentHTML.split(*)` with RegExp almost 80 times slower than a plain string.

Before:
![telegram-cloud-photo-size-2-5409140542421448593-y](https://user-images.githubusercontent.com/22259080/149506024-84365840-5b0f-481f-b05f-1381d839c579.jpg)


After:
![telegram-cloud-photo-size-2-5409140542421448594-y](https://user-images.githubusercontent.com/22259080/149506036-0df69ae7-e265-40da-a865-73c84496aa58.jpg)
@vercel vercel locked as resolved and limited conversation to collaborators Feb 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants