Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update swc #33063

Merged
merged 12 commits into from
Jan 10, 2022
Merged

Update swc #33063

merged 12 commits into from
Jan 10, 2022

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jan 6, 2022 •
edited
Loading

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

I think #31250 and #31911 is fixed, but it needs some verification.
Currently, compilation fails. I'll fix it tomorrow.

Verify:

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Jan 6, 2022
@ijjk

This comment has been minimized.

Sign in to view
@ijjk ijjk added the examples Issue/PR related to examples label Jan 10, 2022
@kdy1 kdy1 changed the title [DO NOT MERGE] Update swc Update swc Jan 10, 2022
@kdy1 kdy1 marked this pull request as ready for review January 10, 2022 06:31
@ijjk
Copy link
Member

ijjk commented Jan 10, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary kdy1/next.js swc-up-1 Change
buildDuration 16.7s 16.9s ⚠️ +195ms
buildDurationCached 4s 3.8s -173ms
nodeModulesSize 355 MB 355 MB -14 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary kdy1/next.js swc-up-1 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.435 3.422 -0.01
/ avg req/sec 727.7 730.49 +2.79
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.584 1.596 ⚠️ +0.01
/error-in-render avg req/sec 1578.21 1566.61 ⚠️ -11.6
Client Bundles (main, webpack, commons)
vercel/next.js canary kdy1/next.js swc-up-1 Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 27.1 kB 27.1 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 70.9 kB 70.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js swc-up-1 Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary kdy1/next.js swc-up-1 Change
_app-HASH.js gzip 1.37 kB 1.37 kB ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 326 B 326 B ✓
dynamic-HASH.js gzip 2.37 kB 2.37 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 919 B 919 B ✓
image-HASH.js gzip 4.74 kB 4.74 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.13 kB 2.13 kB ✓
routerDirect..HASH.js gzip 321 B 321 B ✓
script-HASH.js gzip 383 B 383 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.1 kB 14.1 kB ✓
Client Build Manifests
vercel/next.js canary kdy1/next.js swc-up-1 Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary kdy1/next.js swc-up-1 Change
index.html gzip 532 B 532 B ✓
link.html gzip 546 B 546 B ✓
withRouter.html gzip 527 B 527 B ✓
Overall change 1.6 kB 1.6 kB ✓
Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary kdy1/next.js swc-up-1 Change
buildDuration 18.7s 18.6s -85ms
buildDurationCached 3.8s 3.7s -48ms
nodeModulesSize 355 MB 355 MB -14 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary kdy1/next.js swc-up-1 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.393 3.49 ⚠️ +0.1
/ avg req/sec 736.9 716.27 ⚠️ -20.63
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.518 1.567 ⚠️ +0.05
/error-in-render avg req/sec 1646.91 1595.64 ⚠️ -51.27
Client Bundles (main, webpack, commons)
vercel/next.js canary kdy1/next.js swc-up-1 Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 27.2 kB 27.2 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71.1 kB 71.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js swc-up-1 Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary kdy1/next.js swc-up-1 Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 305 B 305 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.36 kB 2.36 kB ✓
head-HASH.js gzip 342 B 342 B ✓
hooks-HASH.js gzip 906 B 906 B ✓
image-HASH.js gzip 4.76 kB 4.76 kB ✓
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 2.19 kB 2.19 kB ✓
routerDirect..HASH.js gzip 314 B 314 B ✓
script-HASH.js gzip 375 B 375 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.1 kB 14.1 kB ✓
Client Build Manifests
vercel/next.js canary kdy1/next.js swc-up-1 Change
_buildManifest.js gzip 458 B 458 B ✓
Overall change 458 B 458 B ✓
Rendered Page Sizes
vercel/next.js canary kdy1/next.js swc-up-1 Change
index.html gzip 532 B 532 B ✓
link.html gzip 546 B 546 B ✓
withRouter.html gzip 526 B 526 B ✓
Overall change 1.6 kB 1.6 kB ✓
Commit: b697033

@timneutkens timneutkens merged commit 87dbd03 into vercel:canary Jan 10, 2022
@timneutkens timneutkens deleted the swc-up-1 branch January 10, 2022 10:37
teleaziz added a commit to teleaziz/next.js that referenced this pull request Jan 11, 2022
@teleaziz
Merge branch 'cms-builder-io-example' of github.com:teleaziz/next.js …
ce988af 
…into cms-builder-io-example

* 'cms-builder-io-example' of github.com:teleaziz/next.js: (22 commits)
  drop dynamic import with `ssr: false` on server-side (vercel#32606)
  next-swc: fix ssg code elimination when used in render (vercel#32709)
  Add Caveats section to custom error page (vercel#33160)
  v12.0.8-canary.20
  Allow dependencies to use environment variables in middlewares (vercel#33141)
  use a separate webpack runtime for middleware (vercel#33134)
  No info on environment variables in the src folder (vercel#33110) (vercel#33136)
  docs: minor text-copy cleanup (vercel#33120)
  Update swc (vercel#33063)
  Update next.config.js (vercel#33091)
  Adding Asset Component for Rich Text Renderer (vercel#32503)
  Update using-mdx.md (vercel#33077)
  v12.0.8-canary.19
  Fix middleware at root in standalone mode (vercel#33053)
  Add util for generating new tests/error documents (vercel#33001)
  Remove extra config from tailwind example (vercel#33062)
  Fix link for Next.js Analytics in docs (vercel#33049)
  Bump `@vercel/nft` to 0.17.2 (vercel#33048)
  Update deployment documentation. (vercel#32006)
  v12.0.8-canary.18
  ...
@vercel vercel locked as resolved and limited conversation to collaborators Feb 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@huozhi huozhi Awaiting requested review from huozhi

@ijjk ijjk Awaiting requested review from ijjk

@leerob leerob Awaiting requested review from leerob

@shuding shuding Awaiting requested review from shuding

@steven-tey steven-tey Awaiting requested review from steven-tey

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team. examples Issue/PR related to examples type: next
Projects
None yet
Milestone
No milestone
3 participants
@kdy1 @ijjk @timneutkens