-
Notifications
You must be signed in to change notification settings - Fork 26.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken yarn pnp #32867
Fix broken yarn pnp #32867
Conversation
1258ffa
to
087cf9b
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Can't wait for this, because of broken PnP we have to stay on Next 11. Thanks a lot) |
abcbafd
to
1330e6c
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is definitely invalid in our lockfile, but afaik our lockfile doesn't affect next.js users at all. So I don't think this will fix any problem.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Stats from current PRDefault Build (Increase detected
|
vercel/next.js canary | kaykdm/next.js fix/yarn-pnp-error | Change | |
---|---|---|---|
buildDuration | 14s | 14s | |
buildDurationCached | 3.1s | 3.1s | |
nodeModulesSize | 355 MB | 355 MB | -8.75 kB |
Page Load Tests Overall increase ✓
vercel/next.js canary | kaykdm/next.js fix/yarn-pnp-error | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.827 | 2.861 | |
/ avg req/sec | 884.24 | 873.85 | |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.293 | 1.277 | -0.02 |
/error-in-render avg req/sec | 1933.16 | 1957.98 | +24.82 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | kaykdm/next.js fix/yarn-pnp-error | Change | |
---|---|---|---|
450.HASH.js gzip | 179 B | 179 B | ✓ |
framework-HASH.js gzip | 42.2 kB | 42.2 kB | ✓ |
main-HASH.js gzip | 27.1 kB | 27.1 kB | ✓ |
webpack-HASH.js gzip | 1.45 kB | 1.45 kB | ✓ |
Overall change | 70.9 kB | 70.9 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | kaykdm/next.js fix/yarn-pnp-error | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | kaykdm/next.js fix/yarn-pnp-error | Change | |
---|---|---|---|
_app-HASH.js gzip | 1.37 kB | 1.37 kB | ✓ |
_error-HASH.js gzip | 194 B | 194 B | ✓ |
amp-HASH.js gzip | 312 B | 312 B | ✓ |
css-HASH.js gzip | 326 B | 326 B | ✓ |
dynamic-HASH.js gzip | 2.37 kB | 2.37 kB | ✓ |
head-HASH.js gzip | 350 B | 350 B | ✓ |
hooks-HASH.js gzip | 919 B | 919 B | ✓ |
image-HASH.js gzip | 4.74 kB | 4.74 kB | ✓ |
index-HASH.js gzip | 263 B | 263 B | ✓ |
link-HASH.js gzip | 2.13 kB | 2.13 kB | ✓ |
routerDirect..HASH.js gzip | 321 B | 321 B | ✓ |
script-HASH.js gzip | 383 B | 383 B | ✓ |
withRouter-HASH.js gzip | 318 B | 318 B | ✓ |
85e02e95b279..7e3.css gzip | 107 B | 107 B | ✓ |
Overall change | 14.1 kB | 14.1 kB | ✓ |
Client Build Manifests
vercel/next.js canary | kaykdm/next.js fix/yarn-pnp-error | Change | |
---|---|---|---|
_buildManifest.js gzip | 459 B | 459 B | ✓ |
Overall change | 459 B | 459 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | kaykdm/next.js fix/yarn-pnp-error | Change | |
---|---|---|---|
index.html gzip | 533 B | 533 B | ✓ |
link.html gzip | 547 B | 547 B | ✓ |
withRouter.html gzip | 528 B | 528 B | ✓ |
Overall change | 1.61 kB | 1.61 kB | ✓ |
Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary | kaykdm/next.js fix/yarn-pnp-error | Change | |
---|---|---|---|
buildDuration | 15.3s | 15.5s | |
buildDurationCached | 3.1s | 3.1s | |
nodeModulesSize | 355 MB | 355 MB | -8.75 kB |
Page Load Tests Overall decrease ⚠️
vercel/next.js canary | kaykdm/next.js fix/yarn-pnp-error | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.836 | 2.869 | |
/ avg req/sec | 881.56 | 871.27 | |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.28 | 1.283 | 0 |
/error-in-render avg req/sec | 1953.19 | 1949.04 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | kaykdm/next.js fix/yarn-pnp-error | Change | |
---|---|---|---|
450.HASH.js gzip | 179 B | 179 B | ✓ |
framework-HASH.js gzip | 42.3 kB | 42.3 kB | ✓ |
main-HASH.js gzip | 27.2 kB | 27.2 kB | ✓ |
webpack-HASH.js gzip | 1.44 kB | 1.44 kB | ✓ |
Overall change | 71.1 kB | 71.1 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | kaykdm/next.js fix/yarn-pnp-error | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | kaykdm/next.js fix/yarn-pnp-error | Change | |
---|---|---|---|
_app-HASH.js gzip | 1.35 kB | 1.35 kB | ✓ |
_error-HASH.js gzip | 180 B | 180 B | ✓ |
amp-HASH.js gzip | 305 B | 305 B | ✓ |
css-HASH.js gzip | 321 B | 321 B | ✓ |
dynamic-HASH.js gzip | 2.36 kB | 2.36 kB | ✓ |
head-HASH.js gzip | 342 B | 342 B | ✓ |
hooks-HASH.js gzip | 906 B | 906 B | ✓ |
image-HASH.js gzip | 4.76 kB | 4.76 kB | ✓ |
index-HASH.js gzip | 256 B | 256 B | ✓ |
link-HASH.js gzip | 2.19 kB | 2.19 kB | ✓ |
routerDirect..HASH.js gzip | 314 B | 314 B | ✓ |
script-HASH.js gzip | 375 B | 375 B | ✓ |
withRouter-HASH.js gzip | 309 B | 309 B | ✓ |
85e02e95b279..7e3.css gzip | 107 B | 107 B | ✓ |
Overall change | 14.1 kB | 14.1 kB | ✓ |
Client Build Manifests
vercel/next.js canary | kaykdm/next.js fix/yarn-pnp-error | Change | |
---|---|---|---|
_buildManifest.js gzip | 458 B | 458 B | ✓ |
Overall change | 458 B | 458 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | kaykdm/next.js fix/yarn-pnp-error | Change | |
---|---|---|---|
index.html gzip | 532 B | 532 B | ✓ |
link.html gzip | 545 B | 545 B | ✓ |
withRouter.html gzip | 526 B | 526 B | ✓ |
Overall change | 1.6 kB | 1.6 kB | ✓ |
Keen to test this with Yarn 3 once a new canary is out! |
There is @kachkaev, please check out |
I just bumped Next to |
How can we set up automated testing to avoid this kind of regression? |
Yeah having some tests would be nice. I just upgraded from
Let’s create a new issue if anyone else can confirm. You can try it in kachkaev/njt#161 by upgrading What’s interesting is that |
@kachkaev |
Good shout @kaykdm! I had I can confirm that Not sure how difficult it would be to support |
@rauchg You can just check if there is any match for There are two such matches right now BTW. Also, I believe that setting |
…o-example * 'canary' of github.com:vercel/next.js: Added links to data fetching api refs, fixed title (vercel#33221) Removed backticks on data fetching api titles (vercel#33216) middlewares: limit `process.env` to inferred usage (vercel#33186) Fixed broken link (vercel#33209) v12.0.8 v12.0.8-canary.22 Refactor data fetching API docs (vercel#30615) Docs: correct ignorance pattern for .env.local (vercel#32647) Fixes vercel#33153: Updating cross-references from master to main + canary (vercel#33198) v12.0.8-canary.21 Add util for normalizing errors (vercel#33159) Fix broken yarn pnp (vercel#32867)
Regression tests for this are being added in #33236 |
x-ref #31552
x-ref #32115
x-ref #32546
x-ref #32721
Since this PR #31455 is merged,
enhanced-resolve
dependency's resolved field is changed which caused broken yarn pnp.I am not sure how this field has been changed or this is intentional or not
When I install webpack locally,
enhanced-resolve
's resolved field in lock file is alwaysregistry.yarnpkg.com
notcodeload.github.com
Bug
fixes #number
contributing.md
Feature
fixes #number
contributing.md
Documentation / Examples
yarn lint