-
Notifications
You must be signed in to change notification settings - Fork 26.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pre-compile more dependencies #32742
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
# Conflicts: # packages/next/build/webpack-config.ts
This comment has been minimized.
This comment has been minimized.
# Conflicts: # packages/next/package.json
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ijjk
requested review from
huozhi,
padmaia,
shuding and
timneutkens
as code owners
January 14, 2022 16:53
This comment has been minimized.
This comment has been minimized.
styfle
approved these changes
Jan 14, 2022
timneutkens
approved these changes
Jan 17, 2022
Stats from current PRDefault Build (Decrease detected ✓)General Overall decrease ✓
Page Load Tests Overall decrease
|
vercel/next.js canary | ijjk/next.js update/finish-nccing | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.918 | 2.984 | |
/ avg req/sec | 856.62 | 837.76 | |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.352 | 1.373 | |
/error-in-render avg req/sec | 1849.16 | 1820.67 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | ijjk/next.js update/finish-nccing | Change | |
---|---|---|---|
450.HASH.js gzip | 179 B | 179 B | ✓ |
framework-HASH.js gzip | 42.2 kB | 42.2 kB | ✓ |
main-HASH.js gzip | 27.2 kB | 27.2 kB | ✓ |
webpack-HASH.js gzip | 1.44 kB | 1.44 kB | ✓ |
Overall change | 71 kB | 71 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | ijjk/next.js update/finish-nccing | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | ijjk/next.js update/finish-nccing | Change | |
---|---|---|---|
_app-HASH.js gzip | 1.37 kB | 1.37 kB | ✓ |
_error-HASH.js gzip | 194 B | 194 B | ✓ |
amp-HASH.js gzip | 312 B | 312 B | ✓ |
css-HASH.js gzip | 326 B | 326 B | ✓ |
dynamic-HASH.js gzip | 2.37 kB | 2.37 kB | ✓ |
head-HASH.js gzip | 350 B | 350 B | ✓ |
hooks-HASH.js gzip | 919 B | 919 B | ✓ |
image-HASH.js gzip | 4.7 kB | 4.7 kB | ✓ |
index-HASH.js gzip | 263 B | 263 B | ✓ |
link-HASH.js gzip | 2.13 kB | 2.13 kB | ✓ |
routerDirect..HASH.js gzip | 321 B | 321 B | ✓ |
script-HASH.js gzip | 383 B | 383 B | ✓ |
withRouter-HASH.js gzip | 318 B | 318 B | ✓ |
85e02e95b279..7e3.css gzip | 107 B | 107 B | ✓ |
Overall change | 14.1 kB | 14.1 kB | ✓ |
Client Build Manifests
vercel/next.js canary | ijjk/next.js update/finish-nccing | Change | |
---|---|---|---|
_buildManifest.js gzip | 459 B | 459 B | ✓ |
Overall change | 459 B | 459 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | ijjk/next.js update/finish-nccing | Change | |
---|---|---|---|
index.html gzip | 531 B | 531 B | ✓ |
link.html gzip | 545 B | 545 B | ✓ |
withRouter.html gzip | 526 B | 526 B | ✓ |
Overall change | 1.6 kB | 1.6 kB | ✓ |
Diffs
Diff for main-HASH.js
@@ -911,7 +911,9 @@
}
isValidElementType = Object(
(function webpackMissingModule() {
- var e = new Error("Cannot find module 'react-is'");
+ var e = new Error(
+ "Cannot find module 'next/dist/compiled/react-is'"
+ );
e.code = "MODULE_NOT_FOUND";
throw e;
})()
@@ -5696,7 +5698,7 @@
isValidElementType = Object(
(function webpackMissingModule() {
var e = new Error(
- "Cannot find module 'react-is'"
+ "Cannot find module 'next/dist/compiled/react-is'"
);
e.code = "MODULE_NOT_FOUND";
throw e;
Diff for index.html
@@ -19,7 +19,7 @@
defer=""
></script>
<script
- src="/_next/static/chunks/main-b72ca22dbd9e018c.js"
+ src="/_next/static/chunks/main-ff67cafd595aae95.js"
defer=""
></script>
<script
Diff for link.html
@@ -19,7 +19,7 @@
defer=""
></script>
<script
- src="/_next/static/chunks/main-b72ca22dbd9e018c.js"
+ src="/_next/static/chunks/main-ff67cafd595aae95.js"
defer=""
></script>
<script
Diff for withRouter.html
@@ -19,7 +19,7 @@
defer=""
></script>
<script
- src="/_next/static/chunks/main-b72ca22dbd9e018c.js"
+ src="/_next/static/chunks/main-ff67cafd595aae95.js"
defer=""
></script>
<script
Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary | ijjk/next.js update/finish-nccing | Change | |
---|---|---|---|
buildDuration | 15.9s | 15.6s | -308ms |
buildDurationCached | 3.3s | 3.2s | -129ms |
nodeModulesSize | 355 MB | 352 MB | -2.75 MB |
Page Load Tests Overall increase ✓
vercel/next.js canary | ijjk/next.js update/finish-nccing | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.956 | 2.925 | -0.03 |
/ avg req/sec | 845.75 | 854.57 | +8.82 |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.339 | 1.344 | |
/error-in-render avg req/sec | 1866.63 | 1860.24 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | ijjk/next.js update/finish-nccing | Change | |
---|---|---|---|
450.HASH.js gzip | 179 B | 179 B | ✓ |
framework-HASH.js gzip | 42.3 kB | 42.3 kB | ✓ |
main-HASH.js gzip | 27.3 kB | 27.3 kB | ✓ |
webpack-HASH.js gzip | 1.44 kB | 1.44 kB | ✓ |
Overall change | 71.3 kB | 71.3 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | ijjk/next.js update/finish-nccing | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | ijjk/next.js update/finish-nccing | Change | |
---|---|---|---|
_app-HASH.js gzip | 1.35 kB | 1.35 kB | ✓ |
_error-HASH.js gzip | 180 B | 180 B | ✓ |
amp-HASH.js gzip | 305 B | 305 B | ✓ |
css-HASH.js gzip | 321 B | 321 B | ✓ |
dynamic-HASH.js gzip | 2.36 kB | 2.36 kB | ✓ |
head-HASH.js gzip | 342 B | 342 B | ✓ |
hooks-HASH.js gzip | 911 B | 911 B | ✓ |
image-HASH.js gzip | 4.73 kB | 4.73 kB | ✓ |
index-HASH.js gzip | 256 B | 256 B | ✓ |
link-HASH.js gzip | 2.19 kB | 2.19 kB | ✓ |
routerDirect..HASH.js gzip | 314 B | 314 B | ✓ |
script-HASH.js gzip | 375 B | 375 B | ✓ |
withRouter-HASH.js gzip | 309 B | 309 B | ✓ |
85e02e95b279..7e3.css gzip | 107 B | 107 B | ✓ |
Overall change | 14.1 kB | 14.1 kB | ✓ |
Client Build Manifests
vercel/next.js canary | ijjk/next.js update/finish-nccing | Change | |
---|---|---|---|
_buildManifest.js gzip | 459 B | 459 B | ✓ |
Overall change | 459 B | 459 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | ijjk/next.js update/finish-nccing | Change | |
---|---|---|---|
index.html gzip | 531 B | 531 B | ✓ |
link.html gzip | 545 B | 545 B | ✓ |
withRouter.html gzip | 526 B | 526 B | ✓ |
Overall change | 1.6 kB | 1.6 kB | ✓ |
Diffs
Diff for main-HASH.js
@@ -911,7 +911,9 @@
}
isValidElementType = Object(
(function webpackMissingModule() {
- var e = new Error("Cannot find module 'react-is'");
+ var e = new Error(
+ "Cannot find module 'next/dist/compiled/react-is'"
+ );
e.code = "MODULE_NOT_FOUND";
throw e;
})()
@@ -5696,7 +5698,7 @@
isValidElementType = Object(
(function webpackMissingModule() {
var e = new Error(
- "Cannot find module 'react-is'"
+ "Cannot find module 'next/dist/compiled/react-is'"
);
e.code = "MODULE_NOT_FOUND";
throw e;
Diff for index.html
@@ -19,7 +19,7 @@
defer=""
></script>
<script
- src="/_next/static/chunks/main-b72ca22dbd9e018c.js"
+ src="/_next/static/chunks/main-ff67cafd595aae95.js"
defer=""
></script>
<script
Diff for link.html
@@ -19,7 +19,7 @@
defer=""
></script>
<script
- src="/_next/static/chunks/main-b72ca22dbd9e018c.js"
+ src="/_next/static/chunks/main-ff67cafd595aae95.js"
defer=""
></script>
<script
Diff for withRouter.html
@@ -19,7 +19,7 @@
defer=""
></script>
<script
- src="/_next/static/chunks/main-b72ca22dbd9e018c.js"
+ src="/_next/static/chunks/main-ff67cafd595aae95.js"
defer=""
></script>
<script
This was referenced Jan 19, 2022
natew
pushed a commit
to natew/next.js
that referenced
this pull request
Feb 16, 2022
This ncc's some remaining dependencies bringing us under 20 install time dependencies (including nested dependencies), this also reduces install size by another `2.75 MB`. A follow-up PR will investigate a custom install script for our swc packages to allow us to remove the `optionalDependencies` which is slowing down install time as well. x-ref: vercel#32679 x-ref: vercel#32627 x-ref: vercel#31887 x-ref: vercel/styled-jsx#770
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ncc's some remaining dependencies bringing us under 20 install time dependencies (including nested dependencies), this also reduces install size by another
2.75 MB
. A follow-up PR will investigate a custom install script for our swc packages to allow us to remove theoptionalDependencies
which is slowing down install time as well.x-ref: #32679
x-ref: #32627
x-ref: #31887
x-ref: vercel/styled-jsx#770