Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update next export documentation. #31465

Merged
merged 7 commits into from
Nov 30, 2021
Merged

Update next export documentation. #31465

merged 7 commits into from
Nov 30, 2021

Conversation

leerob
Copy link
Member

@leerob leerob commented Nov 15, 2021

This more clearly lists what features are supported and not supported by next export.

docs/advanced-features/static-html-export.md Outdated Show resolved Hide resolved
docs/advanced-features/static-html-export.md Outdated Show resolved Hide resolved
docs/advanced-features/static-html-export.md Outdated Show resolved Hide resolved
docs/advanced-features/static-html-export.md Outdated Show resolved Hide resolved
docs/advanced-features/static-html-export.md Outdated Show resolved Hide resolved
docs/advanced-features/static-html-export.md Outdated Show resolved Hide resolved
Co-authored-by: Rich Haines <hello@richardhaines.dev>
Co-authored-by: Matthew Sweeney <mail@mcs.dev>
@leerob
Copy link
Member Author

leerob commented Nov 28, 2021

Sorry for the slow update, this is now ready for review again 😄

@molebox molebox self-requested a review November 29, 2021 08:45
@molebox
Copy link
Collaborator

molebox commented Nov 29, 2021

@leerob @MaedahBatool looks like we have soem cross over with 2 PRs here: #31906

molebox
molebox previously approved these changes Nov 29, 2021
Copy link
Collaborator

@molebox molebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment regarding a more descriptive heading. Other than that LGTM. There is another PR open that is also working on this section: #31906. Might be good to reach out to @MaedahBatool

docs/advanced-features/static-html-export.md Outdated Show resolved Hide resolved
@leerob
Copy link
Member Author

leerob commented Nov 30, 2021

@molebox Fixed! Ready to ship 😄

@leerob leerob merged commit 6e6bd21 into canary Nov 30, 2021
@leerob leerob deleted the leerob-patch-1 branch November 30, 2021 02:50
kodiakhq bot pushed a commit that referenced this pull request Jan 5, 2022
Building off #31465 for `next export` docs.

- Clearly explains the standard output from `next build`
- Move Dockerfile snippet to example, instead of embedded directly
- Clarify both Vercel and `next start` use the Build API output spec
- Less emphasis on recommending Vercel (more neutrality)
- Mention Middleware & Edge Functions when discussing Vercel
- Add "Going to Production" link at the bottom for related reading
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants