Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fs.realpath to get actual project directory #3020

Closed
wants to merge 3 commits into from
Closed

Use fs.realpath to get actual project directory #3020

wants to merge 3 commits into from

Conversation

sdgluck
Copy link
Contributor

@sdgluck sdgluck commented Sep 30, 2017

In server/build/webpack.js: pass the cwd through fs.realpathSync in order that babel-loader can find the "pages" components when the user is in a directory junction. Without this I would receive the "you may need an appropriate loader" error on compilation (Windows 10).

@timneutkens
Copy link
Member

That travis error is kind of strange. Can you check it @sdgluck

@sdgluck
Copy link
Contributor Author

sdgluck commented Nov 5, 2017

Not sure what's going on with this. Will close and open another, maybe the CI pipeline won't fail then.

@lock
Copy link

lock bot commented May 10, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators May 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants