Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update testing.md #29954

Merged
merged 3 commits into from
May 23, 2022
Merged

Update testing.md #29954

merged 3 commits into from
May 23, 2022

Conversation

iggyzap
Copy link
Contributor

@iggyzap iggyzap commented Oct 15, 2021

I've improved jest configuration that :

  1. Starts collecting test coverage
  2. Does not collect coverage for derived files or coverage info itself
  3. Uses coverage provider that is based on node itself.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes

@iggyzap
Update testing.md
07aa970 
I've improved jest configuration that :
1. Starts collecting test coverage
1. Does not collect coverage for derived files or coverage info itself
1. Uses coverage provider that is based on node itself.
@ijjk ijjk requested a review from balazsorban44 as a code owner May 23, 2022 00:49
@kodiakhq kodiakhq bot merged commit 2f9e241 into vercel:canary May 23, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@huozhi huozhi Awaiting requested review from huozhi

@leerob leerob Awaiting requested review from leerob

@lfades lfades Awaiting requested review from lfades

@molebox molebox Awaiting requested review from molebox

@padmaia padmaia Awaiting requested review from padmaia

@shuding shuding Awaiting requested review from shuding

@styfle styfle Awaiting requested review from styfle

@timneutkens timneutkens Awaiting requested review from timneutkens

@delbaoliveira delbaoliveira Awaiting requested review from delbaoliveira

@balazsorban44 balazsorban44 Awaiting requested review from balazsorban44

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iggyzap @ijjk