Fix tsx workaround, bootstrap next.d.ts, add tslint deps #2885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brikou
commented
Sep 1, 2017
| "jsRules": {}, | ||
| "rules": { | ||
| "quotemark": [true, "single", "jsx-double"], | ||
| "semicolon": [true, "never"] |
There was a problem hiding this comment.
I've changed default rules, to match next.js coding style (but I don't like it). Is it possible to stick to default rules (using double quote and always append semicolons).
brikou
commented
Sep 1, 2017
| "@types/react": "^15.0.1", | ||
| "concurrently": "^3.1.0", | ||
| "typescript": "^2.1.5" | ||
| "@types/node": "8.0.26", |
There was a problem hiding this comment.
This definitions are required by next.d.ts (and url import)
|
@timneutkens do you want me to rebase my PR, otherwise just close it, no problem |
|
@brikou looks okay, just rebase and ping me again, I'll merge 👌 |
|
@timneutkens rebased 👍 |
|
@timneutkens thank you too! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary goal of this PR is to solve issue explain in README by setting jsx to react-native.
Another big idea is to bootstrap a next.d.ts definition file as a reference (quite empty for now) but this is a bootstrap.
I also revamp the example to use next/link and so emphasize that there is no more problem :)