Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade styled-jsx to 4.0.1 #28626

Merged
merged 4 commits into from
Aug 30, 2021
Merged

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Aug 30, 2021

Fix warning of peer dep on yarn (berry version) install

@ijjk
Copy link
Member

ijjk commented Aug 30, 2021

Failing test suites

Commit: 77210b0

test/integration/app-document-remove-hmr/test/index.test.js

  • _app removal HMR > should HMR when _document is removed
Expand output

● _app removal HMR › should HMR when _document is removed

expect(received).toContain(expected) // indexOf

Expected substring: "custom _document"
Received string:    "<head><meta charset=\"utf-8\"><meta name=\"viewport\" content=\"width=device-width\"><meta name=\"next-head-count\" content=\"2\"><noscript data-n-css=\"\"></noscript><script defer=\"\" nomodule=\"\" src=\"/_next/static/chunks/polyfills.js?ts=1630339534270\"></script><script src=\"/_next/static/chunks/webpack.js?ts=1630339534270\" defer=\"\"></script><script src=\"/_next/static/chunks/main.js?ts=1630339534270\" defer=\"\"></script><script src=\"/_next/static/chunks/pages/_app.js?ts=1630339534270\" defer=\"\"></script><script src=\"/_next/static/chunks/pages/index.js?ts=1630339534270\" defer=\"\"></script><script src=\"/_next/static/development/_buildManifest.js?ts=1630339534270\" defer=\"\"></script><script src=\"/_next/static/development/_ssgManifest.js?ts=1630339534270\" defer=\"\"></script><noscript id=\"__next_css__DO_NOT_USE__\"></noscript></head><body><div id=\"__next\"><p>custom _app</p><p>index page</p></div><script src=\"/_next/static/chunks/react-refresh.js?ts=1630339534270\"></script><script id=\"__NEXT_DATA__\" type=\"application/json\">{\"props\":{\"pageProps\":{}},\"page\":\"/\",\"query\":{},\"buildId\":\"development\",\"nextExport\":true,\"autoExport\":true,\"isFallback\":false,\"scriptLoader\":[]}</script><div id=\"__next-build-watcher\" style=\"position: fixed; bottom: 10px; right: 20px; width: 0px; height: 0px; z-index: 99999;\"></div><next-route-announcer><p aria-live=\"assertive\" id=\"__next-route-announcer__\" role=\"alert\" style=\"border: 0px; clip: rect(0px, 0px, 0px, 0px); height: 1px; margin: -1px; overflow: hidden; padding: 0px; position: absolute; width: 1px; white-space: nowrap; overflow-wrap: normal;\"></p></next-route-announcer></body>"

  60 |
  61 |       await check(async () => {
> 62 |         const html = await browser.eval('document.documentElement.innerHTML')
     |                          ^
  63 |         return html.includes('index page updated') &&
  64 |           html.includes('custom _app')
  65 |           ? 'success'

  at Object.<anonymous> (integration/app-document-remove-hmr/test/index.test.js:62:26)

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Aug 30, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary huozhi/next.js upgrade-styled-jsx Change
buildDuration 15.7s 15.3s -337ms
buildDurationCached 3.5s 3.6s ⚠️ +125ms
nodeModulesSize 61.7 MB 61.7 MB -26 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js upgrade-styled-jsx Change
/ failed reqs 0 0
/ total time (seconds) 2.942 2.937 -0.01
/ avg req/sec 849.66 851.33 +1.67
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.872 1.936 ⚠️ +0.06
/error-in-render avg req/sec 1335.79 1291.06 ⚠️ -44.73
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js upgrade-styled-jsx Change
745.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 23.3 kB 23.3 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 67.2 kB 67.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js upgrade-styled-jsx Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js upgrade-styled-jsx Change
_app-HASH.js gzip 979 B 979 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.67 kB 2.67 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 918 B 918 B
image-HASH.js gzip 4.14 kB 4.14 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 318 B 318 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 13 kB 13 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js upgrade-styled-jsx Change
_buildManifest.js gzip 491 B 491 B
Overall change 491 B 491 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js upgrade-styled-jsx Change
index.html gzip 540 B 540 B
link.html gzip 553 B 553 B
withRouter.html gzip 534 B 534 B
Overall change 1.63 kB 1.63 kB

Webpack 4 Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary huozhi/next.js upgrade-styled-jsx Change
buildDuration 12.8s 12.7s -65ms
buildDurationCached 5.4s 5.5s ⚠️ +97ms
nodeModulesSize 61.7 MB 61.7 MB -26 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js upgrade-styled-jsx Change
/ failed reqs 0 0
/ total time (seconds) 3.006 2.976 -0.03
/ avg req/sec 831.62 840.13 +8.51
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.861 1.928 ⚠️ +0.07
/error-in-render avg req/sec 1343.59 1296.86 ⚠️ -46.73
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js upgrade-styled-jsx Change
16.HASH.js gzip 186 B 186 B
677f882d2ed8..HASH.js gzip 14.1 kB 14.1 kB
framework.HASH.js gzip 41.9 kB 41.9 kB
main-HASH.js gzip 10.7 kB 10.7 kB
webpack-HASH.js gzip 1.19 kB 1.19 kB
Overall change 68.1 kB 68.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js upgrade-styled-jsx Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js upgrade-styled-jsx Change
_app-HASH.js gzip 964 B 964 B
_error-HASH.js gzip 3.8 kB 3.8 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
dynamic-HASH.js gzip 2.87 kB 2.87 kB
head-HASH.js gzip 3.06 kB 3.06 kB
hooks-HASH.js gzip 924 B 924 B
index-HASH.js gzip 231 B 231 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 298 B 298 B
script-HASH.js gzip 3.03 kB 3.03 kB
withRouter-HASH.js gzip 295 B 295 B
30809af5c834..565.css gzip 125 B 125 B
Overall change 18.1 kB 18.1 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js upgrade-styled-jsx Change
_buildManifest.js gzip 500 B 500 B
Overall change 500 B 500 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js upgrade-styled-jsx Change
index.html gzip 584 B 584 B
link.html gzip 597 B 597 B
withRouter.html gzip 578 B 578 B
Overall change 1.76 kB 1.76 kB
Commit: c5c6be7

This was referenced Jan 27, 2022
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
@huozhi huozhi deleted the upgrade-styled-jsx branch February 3, 2022 15:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants