-
Notifications
You must be signed in to change notification settings - Fork 26.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove webpack-dev-server #276
Conversation
@@ -144,7 +146,7 @@ export default async function createCompiler (dir, { hotReload = false, dev = fa | |||
path: join(dir, '.next'), | |||
filename: '[name]', | |||
libraryTarget: 'commonjs2', | |||
publicPath: hotReload ? 'http://localhost:3030/' : null | |||
publicPath: hotReload ? '/_webpack' : null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't it be /_webpack/
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, fixed, thanks!
Trying to run a locally built version with getting error
|
Also, when adding a new page (test.js) in /dist/pages
I get the following error:
|
@jonaswindey hmm, I can't reproduce. I did clean install (rm -rf node_modules && npm i). How did you install |
|
@jonaswindey it looks you executed |
@nkzawa if I do this on the latest commit from yesterday that command still works, and not anymore. this was the command I use to run next locally and this allowed me to test pages when creating them under /dist/pages how do you run 'next' locally when you want to test your own examples? |
@jonaswindey these are not supported even if worked before by accident. I recommend to use |
Fixes #236, #102
By using
webpack-hot-middleware
, we can use HMR from our server instead of running a dedicated server (webpack-dev-server).