Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix ignoring-eslint-url during build #26165

Merged
merged 6 commits into from
Jun 16, 2021
Merged

docs: fix ignoring-eslint-url during build #26165

merged 6 commits into from
Jun 16, 2021

Conversation

DavidVaness
Copy link

@DavidVaness DavidVaness commented Jun 16, 2021

Documentation

removes dot from docs link as the terminal appends the dot to the link, which leads to 404

@DavidVaness DavidVaness changed the title fix-ignoring-eslint-url during build docs: fix ignoring-eslint-url during build Jun 16, 2021
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Jun 16, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary DavidVaness/next.js fix-Ignoring-ESLint-link Change
buildDuration 13.6s 14.4s ⚠️ +726ms
buildDurationCached 3.4s 3.4s ⚠️ +11ms
nodeModulesSize 46.4 MB 46.4 MB -2 B
Page Load Tests Overall increase ✓
vercel/next.js canary DavidVaness/next.js fix-Ignoring-ESLint-link Change
/ failed reqs 0 0
/ total time (seconds) 2.614 2.549 -0.06
/ avg req/sec 956.42 980.84 +24.42
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.646 1.613 -0.03
/error-in-render avg req/sec 1518.47 1549.85 +31.38
Client Bundles (main, webpack, commons)
vercel/next.js canary DavidVaness/next.js fix-Ignoring-ESLint-link Change
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 20.2 kB 20.2 kB
webpack-HASH.js gzip 804 B 804 B
Overall change 63 kB 63 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary DavidVaness/next.js fix-Ignoring-ESLint-link Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary DavidVaness/next.js fix-Ignoring-ESLint-link Change
_app-HASH.js gzip 801 B 801 B
_error-HASH.js gzip 3.17 kB 3.17 kB
amp-HASH.js gzip 527 B 527 B
css-HASH.js gzip 329 B 329 B
hooks-HASH.js gzip 903 B 903 B
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.65 kB 1.65 kB
routerDirect..HASH.js gzip 322 B 322 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 8.41 kB 8.41 kB
Client Build Manifests
vercel/next.js canary DavidVaness/next.js fix-Ignoring-ESLint-link Change
_buildManifest.js gzip 391 B 391 B
Overall change 391 B 391 B
Rendered Page Sizes
vercel/next.js canary DavidVaness/next.js fix-Ignoring-ESLint-link Change
index.html gzip 523 B 523 B
link.html gzip 535 B 535 B
withRouter.html gzip 514 B 514 B
Overall change 1.57 kB 1.57 kB

Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary DavidVaness/next.js fix-Ignoring-ESLint-link Change
buildDuration 16.1s 16.3s ⚠️ +215ms
buildDurationCached 4.5s 4.6s ⚠️ +53ms
nodeModulesSize 46.4 MB 46.4 MB -2 B
Client Bundles (main, webpack, commons)
vercel/next.js canary DavidVaness/next.js fix-Ignoring-ESLint-link Change
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 20.2 kB 20.2 kB
webpack-HASH.js gzip 804 B 804 B
Overall change 63 kB 63 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary DavidVaness/next.js fix-Ignoring-ESLint-link Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary DavidVaness/next.js fix-Ignoring-ESLint-link Change
_app-HASH.js gzip 801 B 801 B
_error-HASH.js gzip 3.17 kB 3.17 kB
amp-HASH.js gzip 527 B 527 B
css-HASH.js gzip 329 B 329 B
hooks-HASH.js gzip 903 B 903 B
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.65 kB 1.65 kB
routerDirect..HASH.js gzip 322 B 322 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 8.41 kB 8.41 kB
Client Build Manifests
vercel/next.js canary DavidVaness/next.js fix-Ignoring-ESLint-link Change
_buildManifest.js gzip 391 B 391 B
Overall change 391 B 391 B
Serverless bundles Overall increase ⚠️
vercel/next.js canary DavidVaness/next.js fix-Ignoring-ESLint-link Change
_error.js 16.9 kB 16.9 kB ⚠️ +2 B
404.html 1.98 kB 1.98 kB
500.html 1.96 kB 1.96 kB
amp.amp.html 10.8 kB 10.8 kB
amp.html 1.17 kB 1.17 kB
css.html 1.35 kB 1.35 kB
hooks.html 1.23 kB 1.23 kB
index.js 17.2 kB 17.2 kB
link.js 17.5 kB 17.5 kB
routerDirect.js 17.3 kB 17.3 kB ⚠️ +2 B
withRouter.js 17.3 kB 17.3 kB
Overall change 105 kB 105 kB ⚠️ +4 B

Webpack 4 Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary DavidVaness/next.js fix-Ignoring-ESLint-link Change
buildDuration 12.7s 12.6s -74ms
buildDurationCached 5s 5.2s ⚠️ +203ms
nodeModulesSize 46.4 MB 46.4 MB -2 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary DavidVaness/next.js fix-Ignoring-ESLint-link Change
/ failed reqs 0 0
/ total time (seconds) 2.674 2.721 ⚠️ +0.05
/ avg req/sec 935.06 918.71 ⚠️ -16.35
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.715 1.758 ⚠️ +0.04
/error-in-render avg req/sec 1458.08 1422.22 ⚠️ -35.86
Client Bundles (main, webpack, commons)
vercel/next.js canary DavidVaness/next.js fix-Ignoring-ESLint-link Change
677f882d2ed8..HASH.js gzip 13.4 kB 13.4 kB
framework.HASH.js gzip 41.8 kB 41.8 kB
main-HASH.js gzip 7.99 kB 7.99 kB
webpack-HASH.js gzip 751 B 751 B
Overall change 63.9 kB 63.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary DavidVaness/next.js fix-Ignoring-ESLint-link Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary DavidVaness/next.js fix-Ignoring-ESLint-link Change
_app-HASH.js gzip 1.07 kB 1.07 kB
_error-HASH.js gzip 3.84 kB 3.84 kB
amp-HASH.js gzip 536 B 536 B
css-HASH.js gzip 333 B 333 B
hooks-HASH.js gzip 910 B 910 B
index-HASH.js gzip 227 B 227 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 295 B 295 B
withRouter-HASH.js gzip 292 B 292 B
e025d2764813..52f.css gzip 125 B 125 B
Overall change 9.28 kB 9.28 kB
Client Build Manifests
vercel/next.js canary DavidVaness/next.js fix-Ignoring-ESLint-link Change
_buildManifest.js gzip 420 B 420 B
Overall change 420 B 420 B
Rendered Page Sizes
vercel/next.js canary DavidVaness/next.js fix-Ignoring-ESLint-link Change
index.html gzip 568 B 568 B
link.html gzip 579 B 579 B
withRouter.html gzip 559 B 559 B
Overall change 1.71 kB 1.71 kB
Commit: 955a22f

@kodiakhq kodiakhq bot merged commit b0e09d2 into vercel:canary Jun 16, 2021
@DavidVaness DavidVaness deleted the fix-Ignoring-ESLint-link branch June 16, 2021 16:56
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 24, 2021
## Documentation
removes dot from docs link as the terminal appends the dot to the link, which leads to 404
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants