Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update next/image docs and examples #26150

Merged
merged 2 commits into from
Jun 16, 2021

Conversation

styfle
Copy link
Member

@styfle styfle commented Jun 15, 2021

This updates the next/image docs and examples to add missing information.

@ijjk ijjk added type: documentation examples Issue/PR related to examples labels Jun 15, 2021
atcastle
atcastle previously approved these changes Jun 15, 2021
Copy link
Collaborator

@atcastle atcastle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

/>
<ViewSource pathname="pages/placeholder.js" />
<h1>Image Component With Placeholder</h1>
<Image alt="Mountains" src={mountains} placeholder="blur" />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to make sure this is intentional--this changes the behavior of the page since the image is intrinsically larger than 700x475. It might be worth leaving an example that shows that you can override the intrinsic size of a statically-imported image.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! I removed the layout=responsive so that the width and height will take affect

@kodiakhq kodiakhq bot merged commit e4eed61 into canary Jun 16, 2021
@kodiakhq kodiakhq bot deleted the update-next-image-docs-and-examples branch June 16, 2021 01:26
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 24, 2021
This updates the `next/image` docs and examples to add missing information.
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants