Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix delay between blur image and high res image #25994

Merged
merged 4 commits into from
Jun 10, 2021
Merged

Conversation

styfle
Copy link
Member

@styfle styfle commented Jun 10, 2021

Previously, we had an arbitrary delay of 1500ms but instead we can wait until decoding is complete.

Thanks to @kripod: #25916 (comment)

@shortcut-integration
Copy link

This pull request has been linked to Clubhouse Story #22544: Fix next blur image delay.

timneutkens
timneutkens previously approved these changes Jun 10, 2021
packages/next/client/image.tsx Outdated Show resolved Hide resolved
@ijjk

This comment has been minimized.

packages/next/client/image.tsx Outdated Show resolved Hide resolved
Co-authored-by: Kristóf Poduszló <kripod@protonmail.com>
timneutkens
timneutkens previously approved these changes Jun 10, 2021
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@styfle styfle marked this pull request as draft June 10, 2021 20:18
@styfle styfle marked this pull request as ready for review June 10, 2021 20:36
@ijjk
Copy link
Member

ijjk commented Jun 10, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary vercel/next.js ch22544/fix-blur-delay Change
buildDuration 14.6s 14.8s ⚠️ +171ms
buildDurationCached 3.5s 3.5s ⚠️ +20ms
nodeModulesSize 46.5 MB 46.5 MB -527 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js ch22544/fix-blur-delay Change
/ failed reqs 0 0
/ total time (seconds) 3.023 3 -0.02
/ avg req/sec 827.07 833.29 +6.22
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.698 1.738 ⚠️ +0.04
/error-in-render avg req/sec 1471.99 1438.31 ⚠️ -33.68
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js ch22544/fix-blur-delay Change
framework-HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 20.2 kB 20.2 kB
webpack-HASH.js gzip 804 B 804 B
Overall change 60.3 kB 60.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js ch22544/fix-blur-delay Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary vercel/next.js ch22544/fix-blur-delay Change
_app-HASH.js gzip 801 B 801 B
_error-HASH.js gzip 3.07 kB 3.07 kB
amp-HASH.js gzip 527 B 527 B
css-HASH.js gzip 334 B 334 B
hooks-HASH.js gzip 890 B 890 B
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 333 B 333 B
withRouter-HASH.js gzip 330 B 330 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 8.31 kB 8.31 kB
Client Build Manifests
vercel/next.js canary vercel/next.js ch22544/fix-blur-delay Change
_buildManifest.js gzip 392 B 392 B
Overall change 392 B 392 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js ch22544/fix-blur-delay Change
index.html gzip 573 B 573 B
link.html gzip 581 B 581 B
withRouter.html gzip 568 B 568 B
Overall change 1.72 kB 1.72 kB

Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary vercel/next.js ch22544/fix-blur-delay Change
buildDuration 17.1s 16.7s -416ms
buildDurationCached 5s 5.1s ⚠️ +128ms
nodeModulesSize 46.5 MB 46.5 MB -527 B
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js ch22544/fix-blur-delay Change
framework-HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 20.2 kB 20.2 kB
webpack-HASH.js gzip 804 B 804 B
Overall change 60.3 kB 60.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js ch22544/fix-blur-delay Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary vercel/next.js ch22544/fix-blur-delay Change
_app-HASH.js gzip 801 B 801 B
_error-HASH.js gzip 3.07 kB 3.07 kB
amp-HASH.js gzip 527 B 527 B
css-HASH.js gzip 334 B 334 B
hooks-HASH.js gzip 890 B 890 B
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 333 B 333 B
withRouter-HASH.js gzip 330 B 330 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 8.31 kB 8.31 kB
Client Build Manifests
vercel/next.js canary vercel/next.js ch22544/fix-blur-delay Change
_buildManifest.js gzip 392 B 392 B
Overall change 392 B 392 B
Serverless bundles
vercel/next.js canary vercel/next.js ch22544/fix-blur-delay Change
_error.js 16.9 kB 16.9 kB
404.html 2.44 kB 2.44 kB
500.html 2.43 kB 2.43 kB
amp.amp.html 10.8 kB 10.8 kB
amp.html 1.63 kB 1.63 kB
css.html 1.81 kB 1.81 kB
hooks.html 1.69 kB 1.69 kB
index.js 17.2 kB 17.2 kB
link.js 17.4 kB 17.4 kB
routerDirect.js 17.4 kB 17.4 kB
withRouter.js 17.4 kB 17.4 kB
Overall change 107 kB 107 kB

Webpack 4 Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary vercel/next.js ch22544/fix-blur-delay Change
buildDuration 13s 13.1s ⚠️ +82ms
buildDurationCached 5.2s 5.3s ⚠️ +55ms
nodeModulesSize 46.5 MB 46.5 MB -527 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js ch22544/fix-blur-delay Change
/ failed reqs 0 0
/ total time (seconds) 3.057 3.021 -0.04
/ avg req/sec 817.73 827.44 +9.71
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.678 1.741 ⚠️ +0.06
/error-in-render avg req/sec 1489.63 1435.75 ⚠️ -53.88
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js ch22544/fix-blur-delay Change
677f882d2ed8..HASH.js gzip 13.4 kB 13.4 kB
framework.HASH.js gzip 39 kB 39 kB
main-HASH.js gzip 7.99 kB 7.99 kB
webpack-HASH.js gzip 751 B 751 B
Overall change 61.1 kB 61.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js ch22544/fix-blur-delay Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary vercel/next.js ch22544/fix-blur-delay Change
_app-HASH.js gzip 1.07 kB 1.07 kB
_error-HASH.js gzip 3.74 kB 3.74 kB
amp-HASH.js gzip 536 B 536 B
css-HASH.js gzip 339 B 339 B
hooks-HASH.js gzip 887 B 887 B
index-HASH.js gzip 227 B 227 B
link-HASH.js gzip 1.63 kB 1.63 kB
routerDirect..HASH.js gzip 303 B 303 B
withRouter-HASH.js gzip 302 B 302 B
e025d2764813..52f.css gzip 125 B 125 B
Overall change 9.17 kB 9.17 kB
Client Build Manifests
vercel/next.js canary vercel/next.js ch22544/fix-blur-delay Change
_buildManifest.js gzip 420 B 420 B
Overall change 420 B 420 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js ch22544/fix-blur-delay Change
index.html gzip 627 B 627 B
link.html gzip 633 B 633 B
withRouter.html gzip 620 B 620 B
Overall change 1.88 kB 1.88 kB
Commit: 38c65a8

@styfle styfle changed the title Fix blur image delay Fix delay between blur image and high res image Jun 10, 2021
@styfle styfle merged commit dca59bb into canary Jun 10, 2021
@styfle styfle deleted the ch22544/fix-blur-delay branch June 10, 2021 21:45
janicklas-ralph pushed a commit to janicklas-ralph/next.js that referenced this pull request Jun 11, 2021
Previously, we had an arbitrary delay of 1500ms but instead we can wait until decoding is complete.

Co-authored-by: Kristóf Poduszló <kripod@protonmail.com>
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 16, 2021
Previously, we had an arbitrary delay of 1500ms but instead we can wait until decoding is complete.

Co-authored-by: Kristóf Poduszló <kripod@protonmail.com>
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants