Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure default params are detected after rewrite #25205

Merged
merged 4 commits into from
May 18, 2021
Merged

Ensure default params are detected after rewrite #25205

merged 4 commits into from
May 18, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented May 17, 2021 •
edited
Loading

This ensures we detect default param values in minimal mode even if there's a slight difference from a rewrite taking place.

Bug

  • Related issues linked using fixes #number
  • Integration tests added

@ijjk

This comment has been minimized.

Sign in to view
@ijjk ijjk marked this pull request as ready for review May 17, 2021 23:06
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk
Copy link
Member Author

ijjk commented May 18, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/minimal-params-validate Change
buildDuration 14.7s 14.8s ⚠️ +77ms
buildDurationCached 4.5s 4.4s -158ms
nodeModulesSize 46.7 MB 46.7 MB ⚠️ +254 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/minimal-params-validate Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.461 2.434 -0.03
/ avg req/sec 1015.79 1026.94 +11.15
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.293 1.307 ⚠️ +0.01
/error-in-render avg req/sec 1933.67 1912.39 ⚠️ -21.28
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/minimal-params-validate Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 19.4 kB 19.4 kB ✓
webpack-HASH.js gzip 994 B 994 B ✓
Overall change 59.7 kB 59.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/minimal-params-validate Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/minimal-params-validate Change
_app-HASH.js gzip 1.02 kB 1.02 kB ✓
_error-HASH.js gzip 3.06 kB 3.06 kB ✓
amp-HASH.js gzip 526 B 526 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 262 B 262 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 331 B 331 B ✓
withRouter-HASH.js gzip 329 B 329 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.54 kB 8.54 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/minimal-params-validate Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/minimal-params-validate Change
index.html gzip 561 B 561 B ✓
link.html gzip 570 B 570 B ✓
withRouter.html gzip 558 B 558 B ✓
Overall change 1.69 kB 1.69 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/minimal-params-validate Change
buildDuration 17.4s 17.2s -224ms
buildDurationCached 5.6s 5.6s ⚠️ +88ms
nodeModulesSize 46.7 MB 46.7 MB ⚠️ +254 B
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/minimal-params-validate Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 19.4 kB 19.4 kB ✓
webpack-HASH.js gzip 994 B 994 B ✓
Overall change 59.7 kB 59.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/minimal-params-validate Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/minimal-params-validate Change
_app-HASH.js gzip 1.02 kB 1.02 kB ✓
_error-HASH.js gzip 3.06 kB 3.06 kB ✓
amp-HASH.js gzip 526 B 526 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 262 B 262 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 331 B 331 B ✓
withRouter-HASH.js gzip 329 B 329 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.54 kB 8.54 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/minimal-params-validate Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Serverless bundles Overall decrease ✓
vercel/next.js canary ijjk/next.js fix/minimal-params-validate Change
_error.js 17 kB 17 kB -2 B
404.html 2.42 kB 2.42 kB ✓
500.html 2.41 kB 2.41 kB ✓
amp.amp.html 10.8 kB 10.8 kB ✓
amp.html 1.61 kB 1.61 kB ✓
css.html 1.79 kB 1.79 kB ✓
hooks.html 1.67 kB 1.67 kB ✓
index.js 17.3 kB 17.3 kB ✓
link.js 17.6 kB 17.6 kB ✓
routerDirect.js 17.5 kB 17.5 kB -2 B
withRouter.js 17.6 kB 17.6 kB ✓
Overall change 108 kB 108 kB -4 B
Webpack 4 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/minimal-params-validate Change
buildDuration 12.7s 12.9s ⚠️ +275ms
buildDurationCached 5.4s 5.2s -139ms
nodeModulesSize 46.7 MB 46.7 MB ⚠️ +254 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/minimal-params-validate Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.484 2.549 ⚠️ +0.06
/ avg req/sec 1006.58 980.91 ⚠️ -25.67
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.334 1.347 ⚠️ +0.01
/error-in-render avg req/sec 1874.73 1856.01 ⚠️ -18.72
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/minimal-params-validate Change
677f882d2ed8..HASH.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.26 kB 7.26 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/minimal-params-validate Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/minimal-params-validate Change
_app-HASH.js gzip 1.28 kB 1.28 kB ✓
_error-HASH.js gzip 3.74 kB 3.74 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 339 B 339 B ✓
hooks-HASH.js gzip 887 B 887 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
e025d2764813..52f.css gzip 125 B 125 B ✓
Overall change 9.38 kB 9.38 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/minimal-params-validate Change
_buildManifest.js gzip 420 B 420 B ✓
Overall change 420 B 420 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/minimal-params-validate Change
index.html gzip 614 B 614 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Commit: eaff7bc

@ijjk ijjk merged commit ac7c8f3 into vercel:canary May 18, 2021
@ijjk ijjk deleted the fix/minimal-params-validate branch May 18, 2021 19:24
This was referenced May 19, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced May 19, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Merged
Open
Open
Open
Open
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 1, 2021
@ijjk
Ensure default params are detected after rewrite (vercel#25205)
132e3dc 
* Ensure default params are detected after rewrite

* Add test case

* bump
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@divmain divmain Awaiting requested review from divmain

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ijjk @timneutkens