Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix font optimization failing on some builds #25071

Merged
merged 7 commits into from
May 19, 2021

Conversation

janicklas-ralph
Copy link
Contributor

Bug

fixes #25070 and potentially #24781

@ijjk

This comment has been minimized.

Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test for this change?

@ijjk
Copy link
Member

ijjk commented May 18, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary janicklas-ralph/next.js font Change
buildDuration 11.5s 10.9s -582ms
buildDurationCached 3.4s 3.5s ⚠️ +38ms
nodeModulesSize 46.7 MB 46.7 MB ⚠️ +2.43 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary janicklas-ralph/next.js font Change
/ failed reqs 0 0
/ total time (seconds) 1.917 1.947 ⚠️ +0.03
/ avg req/sec 1304.2 1284.03 ⚠️ -20.17
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.059 1.093 ⚠️ +0.03
/error-in-render avg req/sec 2359.71 2286.82 ⚠️ -72.89
Client Bundles (main, webpack, commons)
vercel/next.js canary janicklas-ralph/next.js font Change
framework-HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 19.4 kB 19.4 kB
webpack-HASH.js gzip 994 B 994 B
Overall change 59.7 kB 59.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary janicklas-ralph/next.js font Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary janicklas-ralph/next.js font Change
_app-HASH.js gzip 1.02 kB 1.02 kB
_error-HASH.js gzip 3.06 kB 3.06 kB
amp-HASH.js gzip 526 B 526 B
css-HASH.js gzip 334 B 334 B
hooks-HASH.js gzip 890 B 890 B
index-HASH.js gzip 262 B 262 B
link-HASH.js gzip 1.65 kB 1.65 kB
routerDirect..HASH.js gzip 331 B 331 B
withRouter-HASH.js gzip 329 B 329 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 8.54 kB 8.54 kB
Client Build Manifests
vercel/next.js canary janicklas-ralph/next.js font Change
_buildManifest.js gzip 390 B 390 B
Overall change 390 B 390 B
Rendered Page Sizes
vercel/next.js canary janicklas-ralph/next.js font Change
index.html gzip 561 B 561 B
link.html gzip 570 B 570 B
withRouter.html gzip 558 B 558 B
Overall change 1.69 kB 1.69 kB

Serverless Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary janicklas-ralph/next.js font Change
buildDuration 13.4s 13.4s ⚠️ +23ms
buildDurationCached 4.2s 4.2s -50ms
nodeModulesSize 46.7 MB 46.7 MB ⚠️ +2.43 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary janicklas-ralph/next.js font Change
framework-HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 19.4 kB 19.4 kB
webpack-HASH.js gzip 994 B 994 B
Overall change 59.7 kB 59.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary janicklas-ralph/next.js font Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary janicklas-ralph/next.js font Change
_app-HASH.js gzip 1.02 kB 1.02 kB
_error-HASH.js gzip 3.06 kB 3.06 kB
amp-HASH.js gzip 526 B 526 B
css-HASH.js gzip 334 B 334 B
hooks-HASH.js gzip 890 B 890 B
index-HASH.js gzip 262 B 262 B
link-HASH.js gzip 1.65 kB 1.65 kB
routerDirect..HASH.js gzip 331 B 331 B
withRouter-HASH.js gzip 329 B 329 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 8.54 kB 8.54 kB
Client Build Manifests
vercel/next.js canary janicklas-ralph/next.js font Change
_buildManifest.js gzip 390 B 390 B
Overall change 390 B 390 B
Serverless bundles Overall decrease ✓
vercel/next.js canary janicklas-ralph/next.js font Change
_error.js 17 kB 17 kB -2 B
404.html 2.42 kB 2.42 kB
500.html 2.41 kB 2.41 kB
amp.amp.html 10.8 kB 10.8 kB
amp.html 1.61 kB 1.61 kB
css.html 1.79 kB 1.79 kB
hooks.html 1.67 kB 1.67 kB
index.js 17.3 kB 17.3 kB -2 B
link.js 17.6 kB 17.6 kB
routerDirect.js 17.5 kB 17.5 kB -2 B
withRouter.js 17.6 kB 17.6 kB
Overall change 108 kB 108 kB -6 B

Webpack 4 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary janicklas-ralph/next.js font Change
buildDuration 9.6s 9.6s -36ms
buildDurationCached 4.1s 4s -154ms
nodeModulesSize 46.7 MB 46.7 MB ⚠️ +2.43 kB
Page Load Tests Overall increase ✓
vercel/next.js canary janicklas-ralph/next.js font Change
/ failed reqs 0 0
/ total time (seconds) 2.042 1.906 -0.14
/ avg req/sec 1224.46 1311.97 +87.51
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.058 1.079 ⚠️ +0.02
/error-in-render avg req/sec 2363.76 2317.6 ⚠️ -46.16
Client Bundles (main, webpack, commons)
vercel/next.js canary janicklas-ralph/next.js font Change
677f882d2ed8..HASH.js gzip 13.3 kB 13.3 kB
framework.HASH.js gzip 39 kB 39 kB
main-HASH.js gzip 7.26 kB 7.26 kB
webpack-HASH.js gzip 751 B 751 B
Overall change 60.3 kB 60.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary janicklas-ralph/next.js font Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary janicklas-ralph/next.js font Change
_app-HASH.js gzip 1.28 kB 1.28 kB
_error-HASH.js gzip 3.74 kB 3.74 kB
amp-HASH.js gzip 536 B 536 B
css-HASH.js gzip 339 B 339 B
hooks-HASH.js gzip 887 B 887 B
index-HASH.js gzip 227 B 227 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 303 B 303 B
withRouter-HASH.js gzip 302 B 302 B
e025d2764813..52f.css gzip 125 B 125 B
Overall change 9.38 kB 9.38 kB
Client Build Manifests
vercel/next.js canary janicklas-ralph/next.js font Change
_buildManifest.js gzip 420 B 420 B
Overall change 420 B 420 B
Rendered Page Sizes
vercel/next.js canary janicklas-ralph/next.js font Change
index.html gzip 614 B 614 B
link.html gzip 620 B 620 B
withRouter.html gzip 607 B 607 B
Overall change 1.84 kB 1.84 kB
Commit: e3ce13e

This was referenced May 19, 2021
@janicklas-ralph janicklas-ralph deleted the font branch May 21, 2021 20:12
@DoctorDerek
Copy link

Just wanted to say thank you to @janicklas-ralph -- I ran into this issue already and great to see you not only fixed & tested it, but you merged it already into canary.

flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 1, 2021
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Font optimization doesn't work on some builds
4 participants