Bump next-babel-loader cache key #24335

ijjk · 2021-04-22T02:47:43Z

This bumps the babel cache key since we modified the react-loadable babel plugin and we don't want any cached versions used since the module names generated in previous cached version won't match the newly expected values.

x-ref: #24281

Bug

Related issues linked using fixes #number
Integration tests added

Feature

Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
Related issues linked using fixes #number
Integration tests added
Documentation added
Telemetry added. In case of a feature if it's used or not.

Documentation / Examples

Make sure the linting passes

ijjk · 2021-04-22T03:00:56Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General

	vercel/next.js canary	ijjk/next.js bump/babel-cache-key	Change
buildDuration	16.2s	16.7s	⚠️ +491ms
buildDurationCached	5.3s	5.3s	-4ms
nodeModulesSize	46.6 MB	46.6 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	ijjk/next.js bump/babel-cache-key	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.758	2.903	⚠️ +0.15
/ avg req/sec	906.54	861.28	⚠️ -45.26
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.771	1.665	-0.11
/error-in-render avg req/sec	1411.38	1501.57	+90.19

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js bump/babel-cache-key	Change
597-HASH.js gzip	13.3 kB	13.3 kB	✓
778-HASH.js gzip	7.12 kB	7.12 kB	✓
framework-HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	151 B	151 B	✓
webpack-HASH.js gzip	993 B	993 B	✓
Overall change	60.8 kB	60.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js bump/babel-cache-key	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js bump/babel-cache-key	Change
_app-HASH.js gzip	1.3 kB	1.3 kB	✓
_error-HASH.js gzip	3.68 kB	3.68 kB	✓
amp-HASH.js gzip	558 B	558 B	✓
css-HASH.js gzip	363 B	363 B	✓
hooks-HASH.js gzip	924 B	924 B	✓
index-HASH.js gzip	243 B	243 B	✓
link-HASH.js gzip	1.66 kB	1.66 kB	✓
routerDirect..HASH.js gzip	336 B	336 B	✓
withRouter-HASH.js gzip	334 B	334 B	✓
99a142a5cfae..804.css gzip	125 B	125 B	✓
Overall change	9.52 kB	9.52 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js bump/babel-cache-key	Change
_buildManifest.js gzip	390 B	390 B	✓
Overall change	390 B	390 B	✓

Rendered Page Sizes

	vercel/next.js canary	ijjk/next.js bump/babel-cache-key	Change
index.html gzip	610 B	610 B	✓
link.html gzip	615 B	615 B	✓
withRouter.html gzip	604 B	604 B	✓
Overall change	1.83 kB	1.83 kB	✓

Serverless Mode (Decrease detected ✓)

General

	vercel/next.js canary	ijjk/next.js bump/babel-cache-key	Change
buildDuration	20.3s	20.4s	⚠️ +24ms
buildDurationCached	7.4s	7.6s	⚠️ +155ms
nodeModulesSize	46.6 MB	46.6 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js bump/babel-cache-key	Change
597-HASH.js gzip	13.3 kB	13.3 kB	✓
778-HASH.js gzip	7.12 kB	7.12 kB	✓
framework-HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	151 B	151 B	✓
webpack-HASH.js gzip	993 B	993 B	✓
Overall change	60.8 kB	60.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js bump/babel-cache-key	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js bump/babel-cache-key	Change
_app-HASH.js gzip	1.3 kB	1.3 kB	✓
_error-HASH.js gzip	3.68 kB	3.68 kB	✓
amp-HASH.js gzip	558 B	558 B	✓
css-HASH.js gzip	363 B	363 B	✓
hooks-HASH.js gzip	924 B	924 B	✓
index-HASH.js gzip	243 B	243 B	✓
link-HASH.js gzip	1.66 kB	1.66 kB	✓
routerDirect..HASH.js gzip	336 B	336 B	✓
withRouter-HASH.js gzip	334 B	334 B	✓
99a142a5cfae..804.css gzip	125 B	125 B	✓
Overall change	9.52 kB	9.52 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js bump/babel-cache-key	Change
_buildManifest.js gzip	390 B	390 B	✓
Overall change	390 B	390 B	✓

Serverless bundles Overall decrease ✓

	vercel/next.js canary	ijjk/next.js bump/babel-cache-key	Change
_error.js	1.39 MB	1.39 MB	✓
404.html	2.76 kB	2.76 kB	✓
500.html	2.75 kB	2.75 kB	✓
amp.amp.html	10.8 kB	10.8 kB	✓
amp.html	1.96 kB	1.96 kB	✓
css.html	2.13 kB	2.13 kB	✓
hooks.html	2.01 kB	2.01 kB	✓
index.js	1.39 MB	1.39 MB	-2 B
link.js	1.45 MB	1.45 MB	✓
routerDirect.js	1.44 MB	1.44 MB	✓
withRouter.js	1.44 MB	1.44 MB	✓
Overall change	7.15 MB	7.15 MB	-2 B

Webpack 4 Mode (Decrease detected ✓)

General

	vercel/next.js canary	ijjk/next.js bump/babel-cache-key	Change
buildDuration	13.8s	13.8s	-17ms
buildDurationCached	5.7s	5.7s	-23ms
nodeModulesSize	46.6 MB	46.6 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	ijjk/next.js bump/babel-cache-key	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.787	2.8	⚠️ +0.01
/ avg req/sec	897.05	892.96	⚠️ -4.09
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.65	1.709	⚠️ +0.06
/error-in-render avg req/sec	1515.43	1462.88	⚠️ -52.55

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js bump/babel-cache-key	Change
677f882d2ed8..HASH.js gzip	13.4 kB	13.4 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	7.2 kB	7.2 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	60.3 kB	60.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js bump/babel-cache-key	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js bump/babel-cache-key	Change
_app-HASH.js gzip	1.28 kB	1.28 kB	✓
_error-HASH.js gzip	3.71 kB	3.71 kB	✓
amp-HASH.js gzip	536 B	536 B	✓
css-HASH.js gzip	339 B	339 B	✓
hooks-HASH.js gzip	887 B	887 B	✓
index-HASH.js gzip	227 B	227 B	✓
link-HASH.js gzip	1.65 kB	1.65 kB	✓
routerDirect..HASH.js gzip	303 B	303 B	✓
withRouter-HASH.js gzip	302 B	302 B	✓
21c68fa65a48..217.css gzip	125 B	125 B	✓
Overall change	9.36 kB	9.36 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js bump/babel-cache-key	Change
_buildManifest.js gzip	419 B	419 B	✓
Overall change	419 B	419 B	✓

Rendered Page Sizes

	vercel/next.js canary	ijjk/next.js bump/babel-cache-key	Change
index.html gzip	612 B	612 B	✓
link.html gzip	619 B	619 B	✓
withRouter.html gzip	605 B	605 B	✓
Overall change	1.84 kB	1.84 kB	✓

Commit: 37d24a7

ijjk · 2021-04-22T08:11:48Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General

	vercel/next.js canary	ijjk/next.js bump/babel-cache-key	Change
buildDuration	15.6s	15.5s	-117ms
buildDurationCached	5s	4.6s	-378ms
nodeModulesSize	46.6 MB	46.6 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	ijjk/next.js bump/babel-cache-key	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.774	2.747	-0.03
/ avg req/sec	901.29	910.19	+8.9
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.571	1.496	-0.07
/error-in-render avg req/sec	1591.78	1670.79	+79.01

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js bump/babel-cache-key	Change
597-HASH.js gzip	13.3 kB	13.3 kB	✓
778-HASH.js gzip	7.12 kB	7.12 kB	✓
framework-HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	151 B	151 B	✓
webpack-HASH.js gzip	993 B	993 B	✓
Overall change	60.8 kB	60.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js bump/babel-cache-key	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js bump/babel-cache-key	Change
_app-HASH.js gzip	1.3 kB	1.3 kB	✓
_error-HASH.js gzip	3.68 kB	3.68 kB	✓
amp-HASH.js gzip	558 B	558 B	✓
css-HASH.js gzip	363 B	363 B	✓
hooks-HASH.js gzip	924 B	924 B	✓
index-HASH.js gzip	243 B	243 B	✓
link-HASH.js gzip	1.66 kB	1.66 kB	✓
routerDirect..HASH.js gzip	336 B	336 B	✓
withRouter-HASH.js gzip	334 B	334 B	✓
99a142a5cfae..804.css gzip	125 B	125 B	✓
Overall change	9.52 kB	9.52 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js bump/babel-cache-key	Change
_buildManifest.js gzip	390 B	390 B	✓
Overall change	390 B	390 B	✓

Rendered Page Sizes

	vercel/next.js canary	ijjk/next.js bump/babel-cache-key	Change
index.html gzip	609 B	609 B	✓
link.html gzip	615 B	615 B	✓
withRouter.html gzip	604 B	604 B	✓
Overall change	1.83 kB	1.83 kB	✓

Serverless Mode

General

	vercel/next.js canary	ijjk/next.js bump/babel-cache-key	Change
buildDuration	19.1s	19.9s	⚠️ +862ms
buildDurationCached	7.2s	7.5s	⚠️ +231ms
nodeModulesSize	46.6 MB	46.6 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js bump/babel-cache-key	Change
597-HASH.js gzip	13.3 kB	13.3 kB	✓
778-HASH.js gzip	7.12 kB	7.12 kB	✓
framework-HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	151 B	151 B	✓
webpack-HASH.js gzip	993 B	993 B	✓
Overall change	60.8 kB	60.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js bump/babel-cache-key	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js bump/babel-cache-key	Change
_app-HASH.js gzip	1.3 kB	1.3 kB	✓
_error-HASH.js gzip	3.68 kB	3.68 kB	✓
amp-HASH.js gzip	558 B	558 B	✓
css-HASH.js gzip	363 B	363 B	✓
hooks-HASH.js gzip	924 B	924 B	✓
index-HASH.js gzip	243 B	243 B	✓
link-HASH.js gzip	1.66 kB	1.66 kB	✓
routerDirect..HASH.js gzip	336 B	336 B	✓
withRouter-HASH.js gzip	334 B	334 B	✓
99a142a5cfae..804.css gzip	125 B	125 B	✓
Overall change	9.52 kB	9.52 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js bump/babel-cache-key	Change
_buildManifest.js gzip	390 B	390 B	✓
Overall change	390 B	390 B	✓

Serverless bundles Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js bump/babel-cache-key	Change
_error.js	1.39 MB	1.39 MB	✓
404.html	2.76 kB	2.76 kB	✓
500.html	2.75 kB	2.75 kB	✓
amp.amp.html	10.8 kB	10.8 kB	✓
amp.html	1.96 kB	1.96 kB	✓
css.html	2.13 kB	2.13 kB	✓
hooks.html	2.01 kB	2.01 kB	✓
index.js	1.39 MB	1.39 MB	✓
link.js	1.45 MB	1.45 MB	✓
routerDirect.js	1.44 MB	1.44 MB	⚠️ +2 B
withRouter.js	1.44 MB	1.44 MB	⚠️ +2 B
Overall change	7.15 MB	7.15 MB	⚠️ +4 B

Webpack 4 Mode (Increase detected ⚠️)

General

	vercel/next.js canary	ijjk/next.js bump/babel-cache-key	Change
buildDuration	13.5s	13.3s	-151ms
buildDurationCached	5.6s	5.5s	-77ms
nodeModulesSize	46.6 MB	46.6 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	ijjk/next.js bump/babel-cache-key	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.716	2.794	⚠️ +0.08
/ avg req/sec	920.38	894.72	⚠️ -25.66
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.637	1.603	-0.03
/error-in-render avg req/sec	1527.45	1559.84	+32.39

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js bump/babel-cache-key	Change
677f882d2ed8..HASH.js gzip	13.4 kB	13.4 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	7.2 kB	7.2 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	60.3 kB	60.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js bump/babel-cache-key	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js bump/babel-cache-key	Change
_app-HASH.js gzip	1.28 kB	1.28 kB	✓
_error-HASH.js gzip	3.71 kB	3.71 kB	✓
amp-HASH.js gzip	536 B	536 B	✓
css-HASH.js gzip	339 B	339 B	✓
hooks-HASH.js gzip	887 B	887 B	✓
index-HASH.js gzip	227 B	227 B	✓
link-HASH.js gzip	1.65 kB	1.65 kB	✓
routerDirect..HASH.js gzip	303 B	303 B	✓
withRouter-HASH.js gzip	302 B	302 B	✓
21c68fa65a48..217.css gzip	125 B	125 B	✓
Overall change	9.36 kB	9.36 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js bump/babel-cache-key	Change
_buildManifest.js gzip	419 B	419 B	✓
Overall change	419 B	419 B	✓

Rendered Page Sizes

	vercel/next.js canary	ijjk/next.js bump/babel-cache-key	Change
index.html gzip	611 B	611 B	✓
link.html gzip	620 B	620 B	✓
withRouter.html gzip	605 B	605 B	✓
Overall change	1.84 kB	1.84 kB	✓

Commit: c75f31b

Bump next-babel-loader cache key

37d24a7

ijjk requested review from divmain, lfades, shuding and timneutkens as code owners April 22, 2021 02:47

ijjk added the type: next label Apr 22, 2021

timneutkens approved these changes Apr 22, 2021

View reviewed changes

Merge branch 'canary' into bump/babel-cache-key

c75f31b

kodiakhq bot merged commit 1caa7f4 into vercel:canary Apr 22, 2021

sync-by-unito bot mentioned this pull request May 18, 2021

chore(deps): bump next from 10.0.7 to 10.2.0 filecoin-project/slate#736

Closed

vercel locked as resolved and limited conversation to collaborators Jan 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump next-babel-loader cache key #24335

Bump next-babel-loader cache key #24335

ijjk commented Apr 22, 2021

ijjk commented Apr 22, 2021

ijjk commented Apr 22, 2021

Bump next-babel-loader cache key #24335

Bump next-babel-loader cache key #24335

Conversation

ijjk commented Apr 22, 2021

Bug

Feature

Documentation / Examples

ijjk commented Apr 22, 2021

Stats from current PR

ijjk commented Apr 22, 2021

Stats from current PR