Add failing test for server-side compilation error #24054

timneutkens · 2021-04-14T12:51:09Z

Related issue: #24056

Bug

Related issues linked using fixes #number
Integration tests added

Feature

Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
Related issues linked using fixes #number
Integration tests added
Documentation added
Telemetry added. In case of a feature if it's used or not.

Documentation / Examples

Make sure the linting passes

ijjk · 2021-04-14T13:03:11Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	vercel/next.js canary	timneutkens/next.js fix/failing-test-404-compilation-error	Change
buildDuration	15.1s	15.3s	⚠️ +211ms
nodeModulesSize	46.2 MB	46.2 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	timneutkens/next.js fix/failing-test-404-compilation-error	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.699	2.675	-0.02
/ avg req/sec	926.2	934.49	+8.29
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.513	1.535	⚠️ +0.02
/error-in-render avg req/sec	1652.65	1628.61	⚠️ -24.04

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js fix/failing-test-404-compilation-error	Change
597-3f457946..288d.js gzip	13.3 kB	13.3 kB	✓
778-9c11a899..1178.js gzip	7.05 kB	7.05 kB	✓
framework.HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	151 B	151 B	✓
webpack-HASH.js gzip	993 B	993 B	✓
Overall change	60.8 kB	60.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js fix/failing-test-404-compilation-error	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js fix/failing-test-404-compilation-error	Change
_app-5cc66b2..6f03.js gzip	1.3 kB	1.3 kB	✓
_error-55112..054d.js gzip	3.68 kB	3.68 kB	✓
amp-89a5460c..567f.js gzip	558 B	558 B	✓
hooks-8c2e74..be37.js gzip	924 B	924 B	✓
index-fec729..83b2.js gzip	243 B	243 B	✓
link-dd34d9b..0ade.js gzip	1.66 kB	1.66 kB	✓
routerDirect..5759.js gzip	336 B	336 B	✓
withRouter-1..98bf.js gzip	334 B	334 B	✓
Overall change	9.03 kB	9.03 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js fix/failing-test-404-compilation-error	Change
_buildManifest.js gzip	349 B	349 B	✓
Overall change	349 B	349 B	✓

Rendered Page Sizes

	vercel/next.js canary	timneutkens/next.js fix/failing-test-404-compilation-error	Change
index.html gzip	609 B	609 B	✓
link.html gzip	616 B	616 B	✓
withRouter.html gzip	605 B	605 B	✓
Overall change	1.83 kB	1.83 kB	✓

Serverless Mode

General

	vercel/next.js canary	timneutkens/next.js fix/failing-test-404-compilation-error	Change
buildDuration	18.9s	19.1s	⚠️ +184ms
nodeModulesSize	46.2 MB	46.2 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js fix/failing-test-404-compilation-error	Change
597-3f457946..288d.js gzip	13.3 kB	13.3 kB	✓
778-9c11a899..1178.js gzip	7.05 kB	7.05 kB	✓
framework.HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	151 B	151 B	✓
webpack-HASH.js gzip	993 B	993 B	✓
Overall change	60.8 kB	60.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js fix/failing-test-404-compilation-error	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js fix/failing-test-404-compilation-error	Change
_app-5cc66b2..6f03.js gzip	1.3 kB	1.3 kB	✓
_error-55112..054d.js gzip	3.68 kB	3.68 kB	✓
amp-89a5460c..567f.js gzip	558 B	558 B	✓
hooks-8c2e74..be37.js gzip	924 B	924 B	✓
index-fec729..83b2.js gzip	243 B	243 B	✓
link-dd34d9b..0ade.js gzip	1.66 kB	1.66 kB	✓
routerDirect..5759.js gzip	336 B	336 B	✓
withRouter-1..98bf.js gzip	334 B	334 B	✓
Overall change	9.03 kB	9.03 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js fix/failing-test-404-compilation-error	Change
_buildManifest.js gzip	349 B	349 B	✓
Overall change	349 B	349 B	✓

Serverless bundles

	vercel/next.js canary	timneutkens/next.js fix/failing-test-404-compilation-error	Change
_error.js	1.39 MB	1.39 MB	✓
404.html	2.76 kB	2.76 kB	✓
500.html	2.75 kB	2.75 kB	✓
amp.amp.html	10.7 kB	10.7 kB	✓
amp.html	1.96 kB	1.96 kB	✓
hooks.html	2.01 kB	2.01 kB	✓
index.js	1.39 MB	1.39 MB	✓
link.js	1.45 MB	1.45 MB	✓
routerDirect.js	1.44 MB	1.44 MB	✓
withRouter.js	1.44 MB	1.44 MB	✓
Overall change	7.14 MB	7.14 MB	✓

Webpack 5 Mode (Decrease detected ✓)

General

	vercel/next.js canary	timneutkens/next.js fix/failing-test-404-compilation-error	Change
buildDuration	15s	14.8s	-190ms
nodeModulesSize	46.2 MB	46.2 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	timneutkens/next.js fix/failing-test-404-compilation-error	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.65	2.672	⚠️ +0.02
/ avg req/sec	943.46	935.74	⚠️ -7.72
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.54	1.544	0
/error-in-render avg req/sec	1623.63	1618.91	⚠️ -4.72

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js fix/failing-test-404-compilation-error	Change
597-3f457946..288d.js gzip	13.3 kB	13.3 kB	✓
778-9c11a899..1178.js gzip	7.05 kB	7.05 kB	✓
framework.HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	151 B	151 B	✓
webpack-HASH.js gzip	993 B	993 B	✓
Overall change	60.8 kB	60.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js fix/failing-test-404-compilation-error	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js fix/failing-test-404-compilation-error	Change
_app-5cc66b2..6f03.js gzip	1.3 kB	1.3 kB	✓
_error-55112..054d.js gzip	3.68 kB	3.68 kB	✓
amp-89a5460c..567f.js gzip	558 B	558 B	✓
hooks-8c2e74..be37.js gzip	924 B	924 B	✓
index-fec729..83b2.js gzip	243 B	243 B	✓
link-dd34d9b..0ade.js gzip	1.66 kB	1.66 kB	✓
routerDirect..5759.js gzip	336 B	336 B	✓
withRouter-1..98bf.js gzip	334 B	334 B	✓
Overall change	9.03 kB	9.03 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js fix/failing-test-404-compilation-error	Change
_buildManifest.js gzip	349 B	349 B	✓
Overall change	349 B	349 B	✓

Rendered Page Sizes

	vercel/next.js canary	timneutkens/next.js fix/failing-test-404-compilation-error	Change
index.html gzip	609 B	609 B	✓
link.html gzip	616 B	616 B	✓
withRouter.html gzip	605 B	605 B	✓
Overall change	1.83 kB	1.83 kB	✓

Diffs

Diff for index.html

@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "-gxcE0WlRNEJcmjFtwsrR",
+        "buildId": "m1ElCbCFsVGLcgKyss1Q7",
         "isFallback": false,
         "gip": true
       }
@@ -86,11 +86,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/-gxcE0WlRNEJcmjFtwsrR/_buildManifest.js"
+      src="/_next/static/m1ElCbCFsVGLcgKyss1Q7/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/-gxcE0WlRNEJcmjFtwsrR/_ssgManifest.js"
+      src="/_next/static/m1ElCbCFsVGLcgKyss1Q7/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for link.html

@@ -53,7 +53,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "-gxcE0WlRNEJcmjFtwsrR",
+        "buildId": "m1ElCbCFsVGLcgKyss1Q7",
         "isFallback": false,
         "gip": true
       }
@@ -91,11 +91,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/-gxcE0WlRNEJcmjFtwsrR/_buildManifest.js"
+      src="/_next/static/m1ElCbCFsVGLcgKyss1Q7/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/-gxcE0WlRNEJcmjFtwsrR/_ssgManifest.js"
+      src="/_next/static/m1ElCbCFsVGLcgKyss1Q7/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for withRouter.html

@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "-gxcE0WlRNEJcmjFtwsrR",
+        "buildId": "m1ElCbCFsVGLcgKyss1Q7",
         "isFallback": false,
         "gip": true
       }
@@ -86,11 +86,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/-gxcE0WlRNEJcmjFtwsrR/_buildManifest.js"
+      src="/_next/static/m1ElCbCFsVGLcgKyss1Q7/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/-gxcE0WlRNEJcmjFtwsrR/_ssgManifest.js"
+      src="/_next/static/m1ElCbCFsVGLcgKyss1Q7/_ssgManifest.js"
       async=""
     ></script>
   </body>

Commit: 1931c46

ijjk · 2021-04-14T13:23:37Z

Failing test suites

Commit: 1931c46

test/acceptance/ReactRefreshLogBox.dev.test.js

server-side only compilation errors

Expand output

● server-side only compilation errors

expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false

  1283 |   )
  1284 |
> 1285 |   expect(await session.hasRedbox(true)).toBe(true)
       |                                         ^
  1286 |
  1287 |   await cleanup()
  1288 | })

  at Object.<anonymous> (acceptance/ReactRefreshLogBox.dev.test.js:1285:41)

shuding · 2021-04-22T12:19:12Z

Closing as fixed in #24331.

Add failing test for server-side compilation error

1931c46

timneutkens requested review from divmain, ijjk, lfades and shuding as code owners April 14, 2021 12:51

timneutkens mentioned this pull request Apr 14, 2021

Errors in server compilation result in a 404 instead of showing the error overlay #24056

Closed

shuding closed this Apr 22, 2021

vercel locked as resolved and limited conversation to collaborators Jan 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add failing test for server-side compilation error #24054

Add failing test for server-side compilation error #24054

timneutkens commented Apr 14, 2021 •

edited

Loading

ijjk commented Apr 14, 2021

Diffs

ijjk commented Apr 14, 2021

shuding commented Apr 22, 2021

Add failing test for server-side compilation error #24054

Add failing test for server-side compilation error #24054

Conversation

timneutkens commented Apr 14, 2021 • edited Loading

Bug

Feature

Documentation / Examples

ijjk commented Apr 14, 2021

Stats from current PR

Diffs

ijjk commented Apr 14, 2021

Failing test suites

shuding commented Apr 22, 2021

timneutkens commented Apr 14, 2021 •

edited

Loading