Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference to now env example #17341

Merged
merged 1 commit into from
Sep 24, 2020
Merged

Remove reference to now env example #17341

merged 1 commit into from
Sep 24, 2020

Conversation

samrobbins85
Copy link
Contributor

The example has been emptied as it is no longer the recommended way to do it so it shouldn't be linked to

@ijjk
Copy link
Member

ijjk commented Sep 24, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary samrobbins85/next.js patch-2 Change
buildDuration 13.1s 12.3s -829ms
nodeModulesSize 62.9 MB 62.9 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary samrobbins85/next.js patch-2 Change
/ failed reqs 0 0
/ total time (seconds) 2.215 2.269 ⚠️ +0.05
/ avg req/sec 1128.66 1101.62 ⚠️ -27.04
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.14 1.199 ⚠️ +0.06
/error-in-render avg req/sec 2193.6 2084.7 ⚠️ -108.9
Client Bundles (main, webpack, commons)
vercel/next.js canary samrobbins85/next.js patch-2 Change
677f882d2ed8..9339.js gzip 10.9 kB 10.9 kB
framework.HASH.js gzip 39 kB 39 kB
main-ae38113..ffac.js gzip 7.16 kB 7.16 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 57.8 kB 57.8 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary samrobbins85/next.js patch-2 Change
677f882d2ed8..dule.js gzip 6.77 kB 6.77 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-8f43483..dule.js gzip 6.23 kB 6.23 kB
webpack-07c5..dule.js gzip 751 B 751 B
Overall change 52.7 kB 52.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary samrobbins85/next.js patch-2 Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary samrobbins85/next.js patch-2 Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB
hooks-89731c..c609.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.71 kB 7.71 kB
Client Pages Modern
vercel/next.js canary samrobbins85/next.js patch-2 Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-4469a..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.36 kB 5.36 kB
Client Build Manifests
vercel/next.js canary samrobbins85/next.js patch-2 Change
_buildManifest.js gzip 322 B 322 B
_buildManife..dule.js gzip 329 B 329 B
Overall change 651 B 651 B
Rendered Page Sizes
vercel/next.js canary samrobbins85/next.js patch-2 Change
index.html gzip 1 kB 1 kB
link.html gzip 1.01 kB 1.01 kB
withRouter.html gzip 996 B 996 B
Overall change 3.01 kB 3.01 kB

Serverless Mode
General
vercel/next.js canary samrobbins85/next.js patch-2 Change
buildDuration 13.8s 13.9s ⚠️ +116ms
nodeModulesSize 62.9 MB 62.9 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary samrobbins85/next.js patch-2 Change
677f882d2ed8..9339.js gzip 10.9 kB 10.9 kB
framework.HASH.js gzip 39 kB 39 kB
main-ae38113..ffac.js gzip 7.16 kB 7.16 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 57.8 kB 57.8 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary samrobbins85/next.js patch-2 Change
677f882d2ed8..dule.js gzip 6.77 kB 6.77 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-8f43483..dule.js gzip 6.23 kB 6.23 kB
webpack-07c5..dule.js gzip 751 B 751 B
Overall change 52.7 kB 52.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary samrobbins85/next.js patch-2 Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary samrobbins85/next.js patch-2 Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB
hooks-89731c..c609.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.71 kB 7.71 kB
Client Pages Modern
vercel/next.js canary samrobbins85/next.js patch-2 Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-4469a..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.36 kB 5.36 kB
Client Build Manifests
vercel/next.js canary samrobbins85/next.js patch-2 Change
_buildManifest.js gzip 322 B 322 B
_buildManife..dule.js gzip 329 B 329 B
Overall change 651 B 651 B
Serverless bundles
vercel/next.js canary samrobbins85/next.js patch-2 Change
_error.js 1.06 MB 1.06 MB
404.html 4.34 kB 4.34 kB
hooks.html 3.92 kB 3.92 kB
index.js 1.06 MB 1.06 MB
link.js 1.1 MB 1.1 MB
routerDirect.js 1.1 MB 1.1 MB
withRouter.js 1.1 MB 1.1 MB
Overall change 5.41 MB 5.41 MB
Commit: 092b8c2

Copy link
Member

@lfades lfades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samrobbins85 Thank you! Very 👏 Good 👏 Catch 👏

@kodiakhq kodiakhq bot merged commit c45497e into vercel:canary Sep 24, 2020
@samrobbins85 samrobbins85 deleted the patch-2 branch September 24, 2020 18:31
HitoriSensei pushed a commit to HitoriSensei/next.js that referenced this pull request Sep 26, 2020
The example has been emptied as it is no longer the recommended way to do it so it shouldn't be linked to
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants