Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Examples blogs: fix spelling #17049

Merged
merged 3 commits into from
Sep 13, 2020
Merged

Examples blogs: fix spelling #17049

merged 3 commits into from
Sep 13, 2020

Conversation

Zeko369
Copy link
Contributor

@Zeko369 Zeko369 commented Sep 12, 2020 •
edited
Loading

Throughout some of the blog examples word formatter is spelled as formater, this PR changes all of them to formatter

@ijjk ijjk added the examples Issue/PR related to examples label Sep 12, 2020
@ijjk
Copy link
Member

ijjk commented Sep 12, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary Zeko369/next.js canary Change
buildDuration 12.6s 12.1s -478ms
nodeModulesSize 60 MB 60 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Zeko369/next.js canary Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.175 2.155 -0.02
/ avg req/sec 1149.21 1160.25 +11.04
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.132 1.15 ⚠️ +0.02
/error-in-render avg req/sec 2208.89 2174.42 ⚠️ -34.47
Client Bundles (main, webpack, commons)
vercel/next.js canary Zeko369/next.js canary Change
677f882d2ed8..9339.js gzip 10.9 kB 10.9 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-3d83558..e210.js gzip 7.02 kB 7.02 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.6 kB 57.6 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Zeko369/next.js canary Change
677f882d2ed8..dule.js gzip 6.77 kB 6.77 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-0a101e0..dule.js gzip 6.09 kB 6.09 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.6 kB 52.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Zeko369/next.js canary Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Zeko369/next.js canary Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary Zeko369/next.js canary Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary Zeko369/next.js canary Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Rendered Page Sizes
vercel/next.js canary Zeko369/next.js canary Change
index.html gzip 1 kB 1 kB ✓
link.html gzip 1.01 kB 1.01 kB ✓
withRouter.html gzip 996 B 996 B ✓
Overall change 3.01 kB 3.01 kB ✓
Serverless Mode
General
vercel/next.js canary Zeko369/next.js canary Change
buildDuration 13.3s 13s -297ms
nodeModulesSize 60 MB 60 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary Zeko369/next.js canary Change
677f882d2ed8..9339.js gzip 10.9 kB 10.9 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-3d83558..e210.js gzip 7.02 kB 7.02 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.6 kB 57.6 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Zeko369/next.js canary Change
677f882d2ed8..dule.js gzip 6.77 kB 6.77 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-0a101e0..dule.js gzip 6.09 kB 6.09 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.6 kB 52.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Zeko369/next.js canary Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Zeko369/next.js canary Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary Zeko369/next.js canary Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary Zeko369/next.js canary Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Serverless bundles
vercel/next.js canary Zeko369/next.js canary Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.34 kB 4.34 kB ✓
hooks.html 3.92 kB 3.92 kB ✓
index.js 1.04 MB 1.04 MB ✓
link.js 1.08 MB 1.08 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.31 MB 5.31 MB ✓
Commit: a2475cf

@ijjk
Copy link
Member

ijjk commented Sep 12, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary Zeko369/next.js canary Change
buildDuration 12.7s 12.4s -292ms
nodeModulesSize 60 MB 60 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Zeko369/next.js canary Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.258 2.332 ⚠️ +0.07
/ avg req/sec 1107.01 1071.99 ⚠️ -35.02
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.219 1.286 ⚠️ +0.07
/error-in-render avg req/sec 2051.37 1943.54 ⚠️ -107.83
Client Bundles (main, webpack, commons)
vercel/next.js canary Zeko369/next.js canary Change
677f882d2ed8..9339.js gzip 10.9 kB 10.9 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-3d83558..e210.js gzip 7.02 kB 7.02 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.6 kB 57.6 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Zeko369/next.js canary Change
677f882d2ed8..dule.js gzip 6.77 kB 6.77 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-0a101e0..dule.js gzip 6.09 kB 6.09 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.6 kB 52.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Zeko369/next.js canary Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Zeko369/next.js canary Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary Zeko369/next.js canary Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary Zeko369/next.js canary Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Rendered Page Sizes
vercel/next.js canary Zeko369/next.js canary Change
index.html gzip 1 kB 1 kB ✓
link.html gzip 1.01 kB 1.01 kB ✓
withRouter.html gzip 996 B 996 B ✓
Overall change 3.01 kB 3.01 kB ✓
Serverless Mode
General
vercel/next.js canary Zeko369/next.js canary Change
buildDuration 14s 14.1s ⚠️ +81ms
nodeModulesSize 60 MB 60 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary Zeko369/next.js canary Change
677f882d2ed8..9339.js gzip 10.9 kB 10.9 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-3d83558..e210.js gzip 7.02 kB 7.02 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.6 kB 57.6 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Zeko369/next.js canary Change
677f882d2ed8..dule.js gzip 6.77 kB 6.77 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-0a101e0..dule.js gzip 6.09 kB 6.09 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.6 kB 52.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Zeko369/next.js canary Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Zeko369/next.js canary Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary Zeko369/next.js canary Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary Zeko369/next.js canary Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Serverless bundles
vercel/next.js canary Zeko369/next.js canary Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.34 kB 4.34 kB ✓
hooks.html 3.92 kB 3.92 kB ✓
index.js 1.04 MB 1.04 MB ✓
link.js 1.08 MB 1.08 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.31 MB 5.31 MB ✓
Commit: 8f7e400

lfades
lfades reviewed Sep 12, 2020
View reviewed changes
Copy link
Member

@lfades lfades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's formatter

@Zeko369
Copy link
Contributor Author

Zeko369 commented Sep 12, 2020

@lfades

I think it's formatter

Sorry, I worded it wrong, it's currently spelled formater and I changed it to formatter

@ijjk
Copy link
Member

ijjk commented Sep 13, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary Zeko369/next.js canary Change
buildDuration 13.1s 12.4s -721ms
nodeModulesSize 60 MB 60 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary Zeko369/next.js canary Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.463 2.368 -0.1
/ avg req/sec 1014.94 1055.58 +40.64
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.496 1.412 -0.08
/error-in-render avg req/sec 1671.12 1770.01 +98.89
Client Bundles (main, webpack, commons)
vercel/next.js canary Zeko369/next.js canary Change
677f882d2ed8..9339.js gzip 10.9 kB 10.9 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-3d83558..e210.js gzip 7.02 kB 7.02 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.6 kB 57.6 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Zeko369/next.js canary Change
677f882d2ed8..dule.js gzip 6.77 kB 6.77 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-0a101e0..dule.js gzip 6.09 kB 6.09 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.6 kB 52.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Zeko369/next.js canary Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Zeko369/next.js canary Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary Zeko369/next.js canary Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary Zeko369/next.js canary Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Rendered Page Sizes
vercel/next.js canary Zeko369/next.js canary Change
index.html gzip 1 kB 1 kB ✓
link.html gzip 1.01 kB 1.01 kB ✓
withRouter.html gzip 996 B 996 B ✓
Overall change 3.01 kB 3.01 kB ✓
Serverless Mode
General
vercel/next.js canary Zeko369/next.js canary Change
buildDuration 14.6s 15.1s ⚠️ +517ms
nodeModulesSize 60 MB 60 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary Zeko369/next.js canary Change
677f882d2ed8..9339.js gzip 10.9 kB 10.9 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-3d83558..e210.js gzip 7.02 kB 7.02 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.6 kB 57.6 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Zeko369/next.js canary Change
677f882d2ed8..dule.js gzip 6.77 kB 6.77 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-0a101e0..dule.js gzip 6.09 kB 6.09 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.6 kB 52.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Zeko369/next.js canary Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Zeko369/next.js canary Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary Zeko369/next.js canary Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary Zeko369/next.js canary Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Serverless bundles
vercel/next.js canary Zeko369/next.js canary Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.34 kB 4.34 kB ✓
hooks.html 3.92 kB 3.92 kB ✓
index.js 1.04 MB 1.04 MB ✓
link.js 1.08 MB 1.08 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.31 MB 5.31 MB ✓
Commit: f7ade57

@kodiakhq kodiakhq bot merged commit 0f41062 into vercel:canary Sep 13, 2020
HitoriSensei pushed a commit to HitoriSensei/next.js that referenced this pull request Sep 26, 2020
@Zeko369
Examples blogs: fix spelling (vercel#17049)
e04f08b 
Throughout some of the blog examples word `formatter` is spelled as `formater`, this PR changes all of them to `formatter`
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lfades lfades lfades left review comments

@timneutkens timneutkens timneutkens approved these changes

@chibicode chibicode Awaiting requested review from chibicode

@ijjk ijjk Awaiting requested review from ijjk

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Zeko369 @ijjk @lfades @timneutkens