Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Support for CSS Module Value Imports #16973

Merged
merged 5 commits into from
Sep 9, 2020
Merged

Add Support for CSS Module Value Imports #16973

merged 5 commits into from
Sep 9, 2020

Conversation

Timer
Copy link
Member

@Timer Timer commented Sep 9, 2020

Fixes #10142
Fixes #11629

@ijjk ijjk added the type: next label Sep 9, 2020
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk
Copy link
Member

ijjk commented Sep 9, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary Timer/next.js hotfix/css-locals Change
buildDuration 11.4s 11.4s -37ms
nodeModulesSize 56.7 MB 57 MB ⚠️ +287 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Timer/next.js hotfix/css-locals Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.152 2.17 ⚠️ +0.02
/ avg req/sec 1161.89 1152.33 ⚠️ -9.56
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.208 1.319 ⚠️ +0.11
/error-in-render avg req/sec 2069.43 1894.76 ⚠️ -174.67
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js hotfix/css-locals Change
677f882d2ed8..a2cc.js gzip 10.8 kB 10.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-6743a22..e6ce.js gzip 7 kB 7 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.5 kB 57.5 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js hotfix/css-locals Change
677f882d2ed8..dule.js gzip 6.62 kB 6.62 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-3b374ae..dule.js gzip 6.07 kB 6.07 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.4 kB 52.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js hotfix/css-locals Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Timer/next.js hotfix/css-locals Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js hotfix/css-locals Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js hotfix/css-locals Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Rendered Page Sizes
vercel/next.js canary Timer/next.js hotfix/css-locals Change
index.html gzip 1 kB 1 kB ✓
link.html gzip 1.01 kB 1.01 kB ✓
withRouter.html gzip 994 B 994 B ✓
Overall change 3 kB 3 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary Timer/next.js hotfix/css-locals Change
buildDuration 13.4s 13.1s -347ms
nodeModulesSize 56.7 MB 57 MB ⚠️ +287 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js hotfix/css-locals Change
677f882d2ed8..a2cc.js gzip 10.8 kB 10.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-6743a22..e6ce.js gzip 7 kB 7 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.5 kB 57.5 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js hotfix/css-locals Change
677f882d2ed8..dule.js gzip 6.62 kB 6.62 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-3b374ae..dule.js gzip 6.07 kB 6.07 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.4 kB 52.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js hotfix/css-locals Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Timer/next.js hotfix/css-locals Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js hotfix/css-locals Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js hotfix/css-locals Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Serverless bundles
vercel/next.js canary Timer/next.js hotfix/css-locals Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.34 kB 4.34 kB ✓
hooks.html 3.92 kB 3.92 kB ✓
index.js 1.03 MB 1.03 MB ✓
link.js 1.08 MB 1.08 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.31 MB 5.31 MB ✓
Commit: 2ae8c1b

@Timer Timer marked this pull request as ready for review September 9, 2020 23:13
@kodiakhq kodiakhq bot merged commit 25cdaab into vercel:canary Sep 9, 2020
@Timer Timer deleted the hotfix/css-locals branch September 9, 2020 23:36
HitoriSensei pushed a commit to HitoriSensei/next.js that referenced this pull request Sep 26, 2020
@Timer
Add Support for CSS Module Value Imports (vercel#16973)
7e22009 
Fixes vercel#10142
Fixes vercel#11629
This was referenced Oct 7, 2020
Closed
Merged
kodiakhq bot pushed a commit that referenced this pull request Oct 8, 2020
@ijjk
Handle css-loader file resolving change (#17724)
ec2ffb4 
This is a follow-up to #16973 which adds handling for the breaking change in the latest version of css-loader that causes unresolved file references in `url` or `import` to cause the build to fail. This fixes it by adding our own resolve checking and when it fails disabling the `css-loader`'s handling of it. 

Fixes: #17701
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lfades lfades lfades approved these changes

@ijjk ijjk Awaiting requested review from ijjk

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
3 participants
@Timer @ijjk @lfades